Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a language page when first starting the application #307

Open
3 tasks done
Tuan1-2-3 opened this issue Jan 24, 2025 · 13 comments
Open
3 tasks done

Add a language page when first starting the application #307

Tuan1-2-3 opened this issue Jan 24, 2025 · 13 comments
Labels
feature: tentative Feature that may be considered for future development but is not yet confirmed or planned. priority: low

Comments

@Tuan1-2-3
Copy link

Problem Statement

Implement a dedicated language selection page that appears when users first launch the application. This will allow users to easily choose their preferred language before proceeding, enhancing accessibility and improving their overall experience.

Proposed Solution

Add a language page when first starting the application

Alternatives Considered

N/A

Additional Context

N/A

Acknowledgements

  • I have searched the existing issues and discussions to ensure this feature has not already been requested.
  • I understand that submitting a request does not guarantee it will be implemented.
  • I have provided all necessary information to clearly explain my request.
@PranshulGG PranshulGG added feature: tentative Feature that may be considered for future development but is not yet confirmed or planned. priority: low labels Jan 24, 2025
@PranshulGG
Copy link
Owner

@Tuan1-2-3 Not sure if it's an important feature since you can already do that in the settings, so the priority is pretty low.

@Tuan1-2-3
Copy link
Author

Tuan1-2-3 commented Jan 24, 2025

@Tuan1-2-3 Not sure if it's an important feature since you can already do that in the settings, so the priority is pretty low.

@PranshulGG
However, there is someone who is not interested in taking the time to search for it in the settings page; instead, they desire immediate access to it.

@PranshulGG
Copy link
Owner

@PranshulGG
However, there is someone who is not interested in taking the time to search for it in the settings page; instead, they desire immediate access to it.

I haven't had any complaints about this bothering anyone. If someone wants to change the language, it's not difficult, and since users will open the settings to change other preferences, adding an extra page just for this seems unnecessary.

@PinguDEV-original
Copy link
Contributor

@PranshulGG maybe add a button in the app settings that make the system settings for the language of the app pop open?

@PranshulGG
Copy link
Owner

@PranshulGG maybe add a button in the app settings that make the system settings for the language of the app pop open?

The app doesn't rely on system settings to change the language.

@Tuan1-2-3
Copy link
Author

Tuan1-2-3 commented Jan 24, 2025

@PranshulGG
However, there is someone who is not interested in taking the time to search for it in the settings page; instead, they desire immediate access to it.

I haven't had any complaints about this bothering anyone. If someone wants to change the language, it's not difficult, and since users will open the settings to change other preferences, adding an extra page just for this seems unnecessary.

That is true. But if a very old person (grandmother, grandfather,...) using it, they won't like to find it. (My experience)

@bugreporter005
Copy link

bugreporter005 commented Jan 25, 2025

@Tuan1-2-3

But if a very old person (grandmother, grandfather,...) using it, they won't like to find it. (My experience)

Doesn't the app already pick up the system language on first startup? It's rather going to be counterintuitive for the vast majority of users, including myself.

@Tuan1-2-3
Copy link
Author

Tuan1-2-3 commented Jan 25, 2025

@Tuan1-2-3

But if a very old person (grandmother, grandfather,...) using it, they won't like to find it. (My experience)

Doesn't the app already pick up the system language on first startup? It's rather going to be counterintuitive for the vast majority of users, including myself.

It automatically sets English as the default language.

@bugreporter005
Copy link

@Tuan1-2-3

Now I see what you mean. Then perhaps the issue should be reconsidered as "syncing app language with the system language on first launch."

@PranshulGG
Copy link
Owner

It automatically sets English as the default language.

It doesn't set it as default; it's just written in English, and other languages replace those strings. Adding sync between app language and system language, @bugreporter005, I'm not sure if that's possible through JS

@Tuan1-2-3
Copy link
Author

It automatically sets English as the default language.

It doesn't set it as default; it's just written in English, and other languages replace those strings. Adding sync between app language and system language, @bugreporter005, I'm not sure if that's possible through JS

So that's why I suggest you to add a language page if sync between app language and system language isn't available.

@bugreporter005
Copy link

I'm not sure if that's possible through JS

Can't this be done with Java?

@PranshulGG
Copy link
Owner

Can't this be done with Java?

It can be done through Java, and it's pretty simple, but the problem I'm facing is:

All the text elements should be rendered before applying language strings.

If they are not rendered, the app will be half in English and half in the selected language, e.g., Chinese.

At startup, the app doesn't render anything because it checks if the location is available. If not, it returns null, which causes no elements to render.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: tentative Feature that may be considered for future development but is not yet confirmed or planned. priority: low
Projects
None yet
Development

No branches or pull requests

4 participants