Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize MetricsBindAddress to MetricsBindPort #793

Open
phoenixwu0229 opened this issue Jan 9, 2025 · 0 comments · May be fixed by #796
Open

optimize MetricsBindAddress to MetricsBindPort #793

phoenixwu0229 opened this issue Jan 9, 2025 · 0 comments · May be fixed by #796
Labels
kind/bug Something isn't working

Comments

@phoenixwu0229
Copy link

What happened:
The targetPort specified in the service.yaml is hardcoded, while the metricsBindAddress is configurable, leading to inconsistent behavior. Additionally, the metrics interface should ideally be exposed at 0.0.0.0, so flexible configuration may not be necessary. Therefore, it is recommended to optimize this to metricsBindPort.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:
hami 2.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
1 participant