Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRD] Simple mode doesn't burst at level 50 #295

Open
CMDRNuffin opened this issue Jan 20, 2025 · 4 comments · May be fixed by #298
Open

[BRD] Simple mode doesn't burst at level 50 #295

CMDRNuffin opened this issue Jan 20, 2025 · 4 comments · May be fixed by #298
Labels
Bug Something isn't working

Comments

@CMDRNuffin
Copy link

Currently, Level 50 and 51 Bards don't auto-burst because Battle Voice hard requires The Wanderer's Minuet to be active, which is acquired on level 52.
In BRD.cs, lines 381, 936 and 1160 need to bypass the Wanderer's Minuet buff check if the level is < 52.

Also, since the ability is learned from a quest, I strongly suggest adding a similar check to raging strikes (so it doesn't go full-manual randomly during that quest battle or if you forget to do the quest before queueing up for MSQ roulette).

@zbee
Copy link
Member

zbee commented Jan 20, 2025

@edewen

@zbee zbee added the Bug Something isn't working label Jan 20, 2025
@zbee
Copy link
Member

zbee commented Jan 20, 2025

Also, since the ability is learned from a quest, I strongly suggest adding a similar check to raging strikes (so it doesn't go full-manual randomly during that quest battle or if you forget to do the quest before queueing up for MSQ roulette).

Did you experience an issue with that happening?
If not, this should already be covered by any LevelChecked() for Raging Strikes.

@CMDRNuffin
Copy link
Author

Also, since the ability is learned from a quest, I strongly suggest adding a similar check to raging strikes (so it doesn't go full-manual randomly during that quest battle or if you forget to do the quest before queueing up for MSQ roulette).

Did you experience an issue with that happening? If not, this should already be covered by any LevelChecked() for Raging Strikes.

I didn't pay attention during the quest tbh, it was just a thought that occured to me while I was writing that. But looking at it more closely, LevelChecked does seem to do that already, yes. Disregard that part then.

@edewen
Copy link
Contributor

edewen commented Jan 20, 2025

An issue Caused by having to swap the buff order for a patch cycle with the Hardcoded openers until i could sort it all out. Not an issue in advanced ST. Porting that buff section to all 4, should have done it in 270. my bad.

@edewen edewen linked a pull request Jan 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants