Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecation] Redundant functionality core.relax_integrality and core.relax_discrete #998

Closed
RomeoV opened this issue May 3, 2019 · 1 comment

Comments

@RomeoV
Copy link
Contributor

RomeoV commented May 3, 2019

Summary

There are currently two transformations both aimed at relaxing discrete variables here and here.
The core.relax_integrality transformation is very basic. It changes the domain to Reals for every variable, irregardless of the previous domain. It also set's the upper and lower bound.

core.relax_discrete is more sophisticated and tries to detect discrete variables and trnasform then to the continuous counterpart (i.e. NonNegativeIntegers->NonNegativeReals). The problem with the implementation is that is doesn't work for cloned models. See discussion in #995 and #326.

Additionally, there only exist tests for core.relax_integrality (as far as I can tell).

How to fix

Imo one of the two functionalities should be deprecated - probably the relax_integrality implementation. It should be noted that to use the functionality on clonded models (neccesary for many algorithms), currently relax_discrete does not work.

@blnicho
Copy link
Member

blnicho commented Jul 29, 2022

Both of these transformations have been deprecated and replaced by the core.relax_integer_vars transformation.

@blnicho blnicho closed this as completed Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants