Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: sic_classification doesn't seem to be consistent with current SIC codes online #356

Closed
jdhoffa opened this issue Mar 19, 2024 · 1 comment · Fixed by #357
Closed
Labels
ADO Add issue to ADO bug an unexpected problem or unintended behavior

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Mar 19, 2024

The codes in the exported sic_classification dataset require 5-digit codes:
Screenshot 2024-03-19 at 09 14 16

The SIC code database only allows codes containing a maximum of 4-digits:
Screenshot 2024-03-19 at 09 14 50

It is very likely that the sic_classification dataset is outdated, as it was first merged 4 years ago.

Possible actions (not mutually exclusive):
Determine if the dataset is referring to some different SIC classification system
Deprecate the sic_classification dataset
Update the sic_classification dataset to the latest version

AB#10292

@jdhoffa jdhoffa added bug an unexpected problem or unintended behavior ADO Add issue to ADO labels Mar 19, 2024
@jdhoffa
Copy link
Member Author

jdhoffa commented Mar 19, 2024

It seems that this system is consistent with the south African SIC codes:
https://www.statssa.gov.za/additional_services/sic/mdvdvmg4.htm#MAJOR%20DIVISIONS,DIVISIONS%20AND%20MAJOR%20GROUPS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADO Add issue to ADO bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant