Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Create <rh-background-image> #1206

Open
zeroedin opened this issue Aug 29, 2023 · 1 comment
Open

[feat] Create <rh-background-image> #1206

zeroedin opened this issue Aug 29, 2023 · 1 comment
Assignees
Labels
feature New feature or request needs discovery Needs discovery needs refinement This issue needs to be refined needs revisiting Outdated issues worth revisiting in the future new component New component to be created

Comments

@zeroedin
Copy link
Collaborator

zeroedin commented Aug 29, 2023

Description

rh-background-image as an improvement on pf-background-image with more feature set and variants. Should allow the image to be used in a container as well as positioned within that container, as well as repeated. Maybe support use of multiple background images as well?

Suggested solution

Background image that could be placed like a standard <img> tag

Possible attributes:
src (string) - required - path to image
src-2x - path to 2x image
src-sm - path to sm image
src-sm-2x - path to sm 2x image
src-lg - path to lg image
// see pf-background-image for more about the src attributes usage as base example
repeat (boolean) - default: false - allow for repeating icons.

Example API

<rh-background-image src="/path/to/image.png" repeat></rh-background-image>

Additional context

Current open PR for <pf-background-image>

@zeroedin zeroedin added the feature New feature or request label Aug 29, 2023
@markcaron
Copy link
Collaborator

CC: @jvanpelt

@markcaron markcaron added needs discovery Needs discovery new component New component to be created labels Sep 6, 2023
@zeroedin zeroedin self-assigned this Sep 14, 2023
@markcaron markcaron added the needs refinement This issue needs to be refined label Sep 15, 2023
@zeroedin zeroedin moved this from Todo to In Progress 🟢 in Red Hat Design System Sep 19, 2023
@zeroedin zeroedin moved this from In Progress 🟢 to Todo in Red Hat Design System Sep 19, 2023
@markcaron markcaron added the needs revisiting Outdated issues worth revisiting in the future label Feb 7, 2024
@hellogreg hellogreg changed the title [feat] <rh-background-image> [feat] Create <rh-background-image> Feb 8, 2024
@zeroedin zeroedin added this to the 2024/Q3 — Clefairy release milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request needs discovery Needs discovery needs refinement This issue needs to be refined needs revisiting Outdated issues worth revisiting in the future new component New component to be created
Projects
Status: Todo
Development

No branches or pull requests

3 participants