From 44f4bd83c2dbc641cb0b17a755757eff152afd4f Mon Sep 17 00:00:00 2001
From: Rello <github@scherello.de>
Date: Mon, 6 Jan 2025 21:56:53 +0100
Subject: [PATCH] report copy is not taking over all properties

---
 CHANGELOG.md | 1 +
 js/filter.js | 8 +++-----
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 04335b18..1763441a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ### Fixed
 - calculated columns: correct percentage formula in total row
+- report copy is not taking over all properties
 
 ## 5.2.2 - 2025-01-05
 ### Added
diff --git a/js/filter.js b/js/filter.js
index fb74e1b0..9874af41 100644
--- a/js/filter.js
+++ b/js/filter.js
@@ -768,8 +768,6 @@ OCA.Analytics.Filter.Backend = {
 
         if (typeof (OCA.Analytics.currentReportData.options.filteroptions) === 'undefined') {
             OCA.Analytics.currentReportData.options.filteroptions = {};
-        } else {
-            OCA.Analytics.currentReportData.options.filteroptions = JSON.stringify(OCA.Analytics.currentReportData.options.filteroptions);
         }
 
         OCA.Analytics.unsavedFilters = false;
@@ -786,9 +784,9 @@ OCA.Analytics.Filter.Backend = {
             body: JSON.stringify({
                 reportId: reportId,
                 chartoptions: JSON.stringify(OCA.Analytics.currentReportData.options.chartoptions),
-                dataoptions: OCA.Analytics.currentReportData.options.dataoptions,
-                filteroptions: OCA.Analytics.currentReportData.options.filteroptions,
-                tableoptions: OCA.Analytics.currentReportData.options.tableoptions,
+                dataoptions: JSON.stringify(OCA.Analytics.currentReportData.options.dataoptions),
+                filteroptions: JSON.stringify(OCA.Analytics.currentReportData.options.filteroptions),
+                tableoptions: JSON.stringify(OCA.Analytics.currentReportData.options.tableoptions),
             })
         })
             .then(response => response.json())