Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The test instance of keystrokes does not implement the interface of browser binding sourced events #31

Open
RobertWHurst opened this issue Nov 8, 2023 · 0 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@RobertWHurst
Copy link
Owner

Originally reported by @noahbrom in #19

Describe the bug
If you use the keystrokes test instance, it will not implement the same interface for events that the browser bindings, which are used by Keystrokes by default. The typescript types also do not reflect this discrepancy.

To Reproduce
Write a unit test using a test instance of keystrokes, and attempt to use a browser binding sourced property on the event.

Expected behavior
The property should be the same as if used with the browser bindings (unless overridden).

@RobertWHurst RobertWHurst self-assigned this Nov 8, 2023
@RobertWHurst RobertWHurst added the bug Something isn't working label Dec 16, 2023
@RobertWHurst RobertWHurst added enhancement New feature or request and removed bug Something isn't working enhancement New feature or request labels Mar 27, 2024
@RobertWHurst RobertWHurst added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant