[BUG] multiple definition of visionary::VisionaryControl::kSessionTimeout

[arrfou99]

I get a multiple definition error that I never got before which is not clear to me why!

After checking it looks like there are two kSessionTimeout defined where we have this constant defined two times:

sick_visionary_cpp_base/src/VisionaryControl.cpp

Line 27 in a2361e4

constexpr std::chrono::seconds VisionaryControl::kSessionTimeout;

sick_visionary_cpp_base/src/VisionaryControl.h

Line 36 in a2361e4

static constexpr std::chrono::seconds kSessionTimeout = std::chrono::seconds(5);

in order to avoid this error I had to remove the line VisionaryControl.cpp and use this in the VisionaryControl.h

 static constexpr std::chrono::seconds kSessionTimeout = std::chrono::seconds(5);

[peichtoSICKAG]

Hi arrfou99,

during our current release process, we noticed this issue again.
according to c++ spec a static constexpr data member which could be accessed via its memory address during runtime needs this additional declaration. Thus we did not change anything within the 1.1.0 release.
In our build matrix MSVC2022 compiler version 19.x, mingw x64 gcc 14.2 and linux native gcc 11.4 we did not face any problems.
If I remember correctly however, there were severeal changes regarding constexpr behaviour between different c++ standard versions.
Thus if you would like to add a combination of compiler / c++ standard where this is a problem we could consider making this conditional for the next release.
Otherwise we'd like to close this issue.

Sincerely
peichtoSICKAG

[robclaes]

I'm having the same issue while integrating this into ROS2 (humble) on default Ubuntu 22 ROS Docker container. In an Ubuntu24 ROS2 (Jazzy) this does not cause an error. Both of them are using the ROS2 colcon build environment.