You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 9, 2017. It is now read-only.
Clearly there should only be two top level expressions in that code.
The instrumented code that astUtil.computeTopLevelExpressions operates on is this:
var o = J$.W(25, 'o', J$.T(17, { p: J$.T(9, 42, 22, false) }, 11, false), o, false, true);
J$.A(49, J$.R(33, 'o', o, false, true), 'p', '+')(J$.T(41, 37, 22, false));
Reporting 41 as a top level expression happens because the implementation of astUtil.computeTopLevelExpressions assigns a nesting depth of zero to J$.T(41, …) because it does not recognize the nestedness of J$.A(…)(J$.T(41, …)), an additional case is needed for that pattern.
(I do have a simple fix, I will do a pull request later)
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It seems that that astUtil.computeTopLevelExpressions has a bug.
The following test fails if it is added to topLevelExprTests.js:
Clearly there should only be two top level expressions in that code.
The instrumented code that
astUtil.computeTopLevelExpressions
operates on is this:Reporting
41
as a top level expression happens because the implementation ofastUtil.computeTopLevelExpressions
assigns a nesting depth of zero toJ$.T(41, …)
because it does not recognize the nestedness ofJ$.A(…)(J$.T(41, …))
, an additional case is needed for that pattern.(I do have a simple fix, I will do a pull request later)
The text was updated successfully, but these errors were encountered: