Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does the code of classification branch has the loss of reg? #4

Open
zimenglan-sysu-512 opened this issue Jul 11, 2019 · 7 comments
Open

Comments

@zimenglan-sysu-512
Copy link

in the paper, before the grid-branch, the proposals from rpn will go through the classificaiton branch. so in the classification branch, it only has the cls-loss? or still has the both cls-loss and reg-loss?

@luxiin
Copy link
Collaborator

luxiin commented Jul 11, 2019

Only cls-loss. We simply discard reg-loss by overriding loss function in BBoxHead.

@zimenglan-sysu-512
Copy link
Author

hi @luxiin
can u show me the code of it, since i can't find it.
thanks.

@luxiin
Copy link
Collaborator

luxiin commented Jul 11, 2019

losses['loss_cls'] = weighted_cross_entropy(

@luxiin
Copy link
Collaborator

luxiin commented Jul 11, 2019

@zimenglan-sysu-512 We override the loss function of BBoxHead, it's original version contains reg loss like this:

losses['loss_reg'] = weighted_smoothl1(

@zimenglan-sysu-512
Copy link
Author

thanks @luxiin
btw, in mmdetection, it seems to use reg-loss in the config file and in the detectors/grid_rcnn.py.

@luxiin
Copy link
Collaborator

luxiin commented Jul 11, 2019

In mmdetection, one can disable the reg-loss explicit in config file like this:
https://github.com/open-mmlab/mmdetection/blob/713e98bc1bfb842760df6be73b9520ee775d3c06/configs/grid_rcnn/grid_rcnn_gn_head_r50_fpn_2x.py#L36
The feature is not implemented in this repo.

@zimenglan-sysu-512
Copy link
Author

u are right.
thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants