-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sign convention docs and proof #248
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
+ Coverage 0.00% 54.28% +54.28%
==========================================
Files 33 46 +13
Lines 1630 1667 +37
==========================================
+ Hits 0 905 +905
+ Misses 1630 762 -868 ☔ View full report in Codecov by Sentry. |
something appears off with this PR, it looks like every single file has been modified by the formatter? |
I truly modified about 15 files. Formatter, maybe a new update, modified a few others. |
Ah OK, makes sense. I removed the ConstantX components and define them simply in the "sign_convention.md" doc for illustration purposes only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks great!
Co-authored-by: Venkateshprasad <[email protected]>
Co-authored-by: Venkateshprasad <[email protected]>
Adding documentation about the applied sign convention. No changes were made to the current library except to add Constant input sources which aligned with the already available input sources. This PR replaces the previous incorrect PR #246.