Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use systems = @named begin .. end idiom to define systems in tutorials #295

Merged
merged 1 commit into from
May 13, 2024
Merged

Use systems = @named begin .. end idiom to define systems in tutorials #295

merged 1 commit into from
May 13, 2024

Conversation

jaakkor2
Copy link
Contributor

Tutorials list all systems in the ODESystem()-function call. This is cumbersome, and one easily forgets to append
the list after adding the actual system and its connections.

systems = @named begin
 ..
end

is a more user friendly pattern.

@jaakkor2
Copy link
Contributor Author

Huh,

Run julia -e '
┌ Error: Some files have not been formatted !!!
└ @ Main none:6
docs/pages.jl
src/Hydraulic/IsothermalCompressible/components.jl
Error: Process completed with exit code 1.

I did not touch src/Hydraulic/IsothermalCompressible/components.jl nor docs/pages.jl.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.35%. Comparing base (76b07b3) to head (c66d73a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
- Coverage   61.56%   54.35%   -7.22%     
==========================================
  Files          46       46              
  Lines        1470     1665     +195     
==========================================
  Hits          905      905              
- Misses        565      760     +195     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 200b13a into SciML:main May 13, 2024
5 of 9 checks passed
@jaakkor2 jaakkor2 deleted the systemsdefinition branch May 15, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants