Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-column dropdown menues do not play on mobile #11

Open
kghbln opened this issue Mar 3, 2018 · 9 comments
Open

Multi-column dropdown menues do not play on mobile #11

kghbln opened this issue Mar 3, 2018 · 9 comments
Labels

Comments

@kghbln
Copy link
Member

kghbln commented Mar 3, 2018

grafik

Playing around with either of these does not help since the column does not detect the with of the screen. (column-count, column-gap, column-rule-style, column-rule-width, column-rule-color, column-rule, column-span, column-width)

I am afraid we need to switch to another menu system.

@kghbln
Copy link
Member Author

kghbln commented Mar 3, 2018

I must note that this is smw.o specific and not stragula specific.

@ivanhercaz
Copy link
Contributor

A solution could be to make a responsive fullscreen menu in for the resolutions in which the menu fails. I haven't tested my idea, and maybe I'm not understanding the whole problem.

@kghbln
Copy link
Member Author

kghbln commented Mar 7, 2018

If you know a solution please proceed. I am currently not sure how to tackle this issue.

@ivanhercaz
Copy link
Contributor

I will try to solve , but I can't promise it 😕

@ivanhercaz
Copy link
Contributor

This is one easy and fast solution to solve the problem. I couldn't test it in my local installation because I couldn't configure correctly the admin menu of Semantic MediaWiki, so I modify the styles of the website with the Firefox's developer tools.

I will made a PR and maybe there we can discuss if it may be a temporal solution or not.
administrator manual semantic mediawiki org

@ivanhercaz
Copy link
Contributor

@kghbln, so with #17 merged, can we close this issue? Then I can post another to make a reminder that we have to research about why we have to use !important and how we can solve it.

Regards,
Iván

@kghbln kghbln added major and removed showstopper labels Mar 10, 2018
@kghbln
Copy link
Member Author

kghbln commented Mar 10, 2018

I'd rather keep this open until I have changed the user menu to tow columns. Apart from that this issue is indeed resolved. The code is already live on s-mw.o

@ivanhercaz
Copy link
Contributor

Oh, yes, I forget the user menu for a moment hehe. Excuse me @kghbln. I will try to look it and ask about the !importance "necessity" in the media query. Thank you for remind me this!

@ivanhercaz
Copy link
Contributor

@kghbln check #20, it's about the !important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants