Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Cluster support improvement #24

Open
kjoe opened this issue Nov 20, 2019 · 1 comment
Open

Redis Cluster support improvement #24

kjoe opened this issue Nov 20, 2019 · 1 comment

Comments

@kjoe
Copy link
Contributor

kjoe commented Nov 20, 2019

Maybe we can use universal redis client rather than separated files and build options (before document it):

https://godoc.org/github.com/go-redis/redis#UniversalClient

What do you think? It's much cleaner to use the same binary in different environments, but ScanKeys() needs some alteration too.

Thanks!

@SergeyTsalkov
Copy link
Owner

Seems reasonable to me, though I've not looked at it too closely. Any downsides to using UniversalClient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants