-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timestamp parse error makes entire id3 tag unreadable #462
Comments
That was what I originally intended to happen, and completely forgot to implement it. 😄
I've never seen a timestamp like this before, though (should be "2015-07-08T16:53:04"). Do you know where the file came from? The parser can already handle multiple common spec violations, and this may be one that should be supported if it comes from some popular software/platform. Besides that though, yeah I do need to fix errors for |
I’ll try to find out the origin. A user sent it to me. |
Unfortunately I don’t know the origin of this file. I’m not sure if it’s likely to be a common occurrence. |
In that case, I don't know if I should include an exception for that mistake. I'll have it just return what it can parse. So |
That sounds like a perfectly reasonable best effort result. Thanks for taking a look at it! |
i also just ran into this ( the git version (as of 4a2bcf5) does not error out, but also does not parse the timestamp |
Hello @hasezoey!
That's not a valid
lofty-rs/lofty/src/id3/v2/read.rs Lines 62 to 71 in 4a2bcf5
Right now, when upgrading ID3v2.3 to ID3v2.4 I have a check to discard the frame if it isn't actually a valid |
on newer versions of yt-dl(p) it is replaced with the # yt-dlp version 2024.08.06
yt-dlp -x --audio-format mp3 --embed-metadata -o "out.mp3" https://www.youtube.com/watch\?v\=XCZcbUcaxoM
ffprobe out.mp3
hexdump -C out.mp3 | less
00000040 20 55 6e 69 74 79 00 54 44 52 43 00 00 00 0a 00 | Unity.TDRC.....|
00000050 00 03 32 30 31 38 30 37 32 36 00 54 58 58 58 00 |..20180726.TXXX.| (PS: one of my uploaded videos) this also currently triggers the lofty error. i dont actually care that much about that tag, only really came here because of the whole probe failing, but wanted to provide more information. |
Dates without separators should be supported since I fixed #452 (not published yet). I haven't had much time to work on Lofty lately, I'd like to get #218 in before getting 0.22.0 released, since it'll probably be my last major update for a bit. Related to that, if you could help test that PR at all it'd be much appreciated. See #218 (comment) |
sorry, didnt re-test with the git version; can confirm that the |
Reproducer
Summary
Trying to parse the attached file gives this error:
Expected behavior
If the timestamp is invalid could it be skipped in relaxed parsing mode?
ffprobe output:
Assets
sample.mp3.zip
The text was updated successfully, but these errors were encountered: