Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider OP_1NEGATE handling in CScriptOp (as per linked issue from Core) #82

Open
dgpv opened this issue Mar 12, 2024 · 1 comment
Open

Consider OP_1NEGATE handling in CScriptOp (as per linked issue from Core) #82

dgpv opened this issue Mar 12, 2024 · 1 comment

Comments

@dgpv
Copy link

dgpv commented Mar 12, 2024 •
edited
Loading

Spotted in Core's test framework: bitcoin/bitcoin#29589

from petertodd#299 :

This is technically a breaking change, so would require a major version bump.

Same for bitcointx.
@dgpv dgpv changed the title Need to fix ix OP_1NEGATE handling in CScriptOp Need to fix OP_1NEGATE handling in CScriptOp Mar 12, 2024
@dgpv dgpv changed the title Need to fix OP_1NEGATE handling in CScriptOp Consider OP_1NEGATE handling in CScriptOp (as per linked issue from Core) Mar 14, 2024
@dgpv
Copy link
Author

dgpv commented Mar 14, 2024

Changing behavior of encode_op_n/decode_op_n is likely not the wise way to do it, I comment on it here: bitcoin/bitcoin#29589 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgpv