New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Healthchecks] Abstract Check class and factorization #3488

Open

rbayet opened this issue Jan 15, 2025 · 0 comments

Assignees

Labels

feature

Collaborator

rbayet commented Jan 15, 2025 •

edited

Loading

To start allowing people to customize a bit the checks (#3432) through the DI and to factorize a bit the code, we would need

an AbstractCheck class with, for the time being, the most commonly used constructor parameters ie
- UrlInterface $urlBuilder
- a new int $sortOrder of default value 10000
those parameters are stored into protected AbstractCheck class members
AbstractCheck is the one implementing getSortOrder (will return the protected variable)
all existing concrete check class extends AbstractCheck
- and do not need anymore to implement getSortOrder

rbayet added the feature label

rbayet assigned vahonc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment