Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clusterclass with kamaji #25

Closed
mxmxchere opened this issue Feb 29, 2024 · 8 comments · Fixed by #104
Closed

Clusterclass with kamaji #25

mxmxchere opened this issue Feb 29, 2024 · 8 comments · Fixed by #104
Assignees
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling needs refinement User stories that need to be refined for further progress

Comments

@mxmxchere
Copy link
Contributor

mxmxchere commented Feb 29, 2024

My very first steps/impression: The controller to create so called tenantcontrolplanes (kamajis core-functionality) works so far pretty nicely. The next layer is to create such a tenantcontrolplane via a cluter-API controlplane (kamajicontrolplane) resource. So far i have not been successful in doing that. Observation: when a kamajicontrolplane resource is created alongside with a supported provider (for example hcloud). The resource is taken care of, otherwise the controller ignores it.

@jschoone jschoone added the Container Issues or pull requests relevant for Team 2: Container Infra and Tooling label Mar 7, 2024
@jschoone
Copy link
Contributor

Kamaji unfortunately currently lacks of a KamajiControlPlaneTemplate which is needed for the ClusterClass AFAIK

@mxmxchere
Copy link
Contributor Author

mxmxchere commented Mar 26, 2024

It lacks a KamajiControlPlane that wants to play with openstack in my setup right now in the first place, but yes you are right, the missing clusterclass template resource will become an issue too.

@chess-knight
Copy link
Member

@mxmxchere mxmxchere moved this from Backlog to Blocked / On hold in Sovereign Cloud Stack Apr 16, 2024
@mxmxchere
Copy link
Contributor Author

In order to keep the amount of clusterstacks to a minimum, this could be implemented as a flag e.g. kamaji_controlplane. This feature can then be used in all clusterstacks (openstack, metal3)

@chess-knight
Copy link
Member

In order to keep the amount of clusterstacks to a minimum, this could be implemented as a flag e.g. kamaji_controlplane. This feature can then be used in all clusterstacks (openstack, metal3)

Good idea, also KubeVirt seems to be supported https://github.com/clastix/cluster-api-control-plane-provider-kamaji?tab=readme-ov-file#-supported-capi-infrastructure-providers

@jschoone jschoone moved this from Blocked / On hold to Backlog in Sovereign Cloud Stack May 30, 2024
@jschoone jschoone added the needs refinement User stories that need to be refined for further progress label May 30, 2024
@chess-knight chess-knight self-assigned this Jun 3, 2024
@chess-knight chess-knight moved this from Backlog to Doing in Sovereign Cloud Stack Jun 4, 2024
@chess-knight
Copy link
Member

chess-knight commented Jun 4, 2024

I created an upstream PR clastix/cluster-api-control-plane-provider-kamaji#107 which adds KamajiControlPlaneTemplate CRD.

@mxmxchere
Copy link
Contributor Author

mxmxchere commented Jun 6, 2024

@chess-knight I don't recall exactly what i did when i tested kamaji, but i pushed some files that i found that had a matching timestamp with this issue to: https://github.com/SovereignCloudStack/cluster-stacks/tree/shared-controlplane-tests

@chess-knight
Copy link
Member

chess-knight commented Jun 13, 2024

Another upstream PR is here clastix/cluster-api-control-plane-provider-kamaji#109

@jschoone jschoone moved this from Doing to In Review in Sovereign Cloud Stack Jun 14, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Sovereign Cloud Stack Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling needs refinement User stories that need to be refined for further progress
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants