From 10184760d646ee418d0b428fed59905e9a9eb4c3 Mon Sep 17 00:00:00 2001
From: bounav <benjamin.fourmond@ip-house.com>
Date: Mon, 16 Dec 2024 11:20:23 +0000
Subject: [PATCH] No longer leaking memory

- DefaultSyntaxProvider and DefaultBindingProver should not be registered as singleton services
---
 .../Extensions/ServiceCollectionExtensions.cs | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/Spark.AspNetCore.Mvc/Extensions/ServiceCollectionExtensions.cs b/src/Spark.AspNetCore.Mvc/Extensions/ServiceCollectionExtensions.cs
index 034d8aa0..837e06d0 100644
--- a/src/Spark.AspNetCore.Mvc/Extensions/ServiceCollectionExtensions.cs
+++ b/src/Spark.AspNetCore.Mvc/Extensions/ServiceCollectionExtensions.cs
@@ -34,37 +34,37 @@ public static IServiceCollection AddSpark(this IServiceCollection services, Acti
                 services.Configure(setupAction);
             }
 
-            // TODO: Reduce memory consumption cause by loading the assembly of the views compiled dynamically
             services
-                .AddSingleton<ISparkLanguageFactory, DefaultLanguageFactory>()
-                .AddSingleton<IRoslynCompilationLink, CSharpLink>()
-                .AddSingleton<IRoslynCompilationLink, VisualBasicLink>()
-                .AddSingleton<IBatchCompiler, RoslynBatchCompiler>();
+                .AddScoped<ISparkLanguageFactory, DefaultLanguageFactory>()
+                .AddScoped<IRoslynCompilationLink, CSharpLink>()
+                .AddScoped<IRoslynCompilationLink, VisualBasicLink>()
+                .AddScoped<IBatchCompiler, RoslynBatchCompiler>();
 
             services
-                .AddSingleton<Spark.ISparkViewEngine, Spark.SparkViewEngine>()
-                .AddSingleton<ISparkSyntaxProvider, DefaultSyntaxProvider>()
+                .AddScoped<Spark.ISparkViewEngine, Spark.SparkViewEngine>()
+                .AddScoped<ISparkSyntaxProvider, DefaultSyntaxProvider>()
                 .AddSingleton<IViewActivatorFactory, DefaultViewActivator>()
                 .AddSingleton<IResourcePathManager, DefaultResourcePathManager>()
                 .AddSingleton<ITemplateLocator, DefaultTemplateLocator>()
-                .AddSingleton<IBindingProvider, DefaultBindingProvider>()
+                .AddScoped<IBindingProvider, DefaultBindingProvider>()
                 .AddSingleton<IViewFolder>(f => f.GetService<ISparkSettings>().CreateDefaultViewFolder())
                 .AddSingleton<ICompiledViewHolder, CompiledViewHolder>()
                 .AddSingleton<IPartialProvider, DefaultPartialProvider>()
                 .AddSingleton<IPartialReferenceProvider, DefaultPartialReferenceProvider>();
 
-            services.AddSingleton<ISparkExtensionFactory>(c => null);
+            services
+                .AddSingleton<ISparkExtensionFactory>(f => null);
 
             services
                 .AddSingleton<IDescriptorBuilder, AspNetCoreDescriptorBuilder>();
 
             services
-                .AddSingleton<ISparkPrecompiler, SparkPrecompiler>();
+                .AddScoped<ISparkPrecompiler, SparkPrecompiler>();
 
             services
                 .AddTransient<IConfigureOptions<MvcOptions>, SparkMvcOptionsSetup>()
                 .AddTransient<IConfigureOptions<MvcViewOptions>, SparkMvcViewOptionsSetup>()
-                .AddSingleton<ISparkViewEngine, SparkViewEngine>();
+                .AddScoped<ISparkViewEngine, SparkViewEngine>();
 
             return services;
         }