Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for generics #99

Open
sedflix opened this issue May 22, 2019 · 0 comments
Open

Support for generics #99

sedflix opened this issue May 22, 2019 · 0 comments

Comments

@sedflix
Copy link
Contributor

sedflix commented May 22, 2019

Currently, we don't support identifying changes which are related generics in Java.
This happens due to two reasons:

  • Ignoring all CtReference in isToIgnore()
  • No labels are assigned to CtReference in gumtree.spoon.builder.LabelFinder.

In the scenario of Class<T>, T has the role of TYPE_ARGUMENT and Class<T> has the role of TYPE. Checking for this pattern in isToIgnore() and making corresponding changes in LabelFinder should help us consider the scenario of generics, but it may also result in consideration of unwanted cases.

For example,
The above conditions lead to a weird failure of one test case, ie: DiffTest.testToString().
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant