Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: enhance CLBOSS experience #50

Closed
chrisguida opened this issue Jul 1, 2022 · 3 comments
Closed

[feat]: enhance CLBOSS experience #50

chrisguida opened this issue Jul 1, 2022 · 3 comments
Assignees

Comments

@chrisguida
Copy link
Contributor

chrisguida commented Jul 1, 2022

  1. Either disable clboss by default, or present a prominent notice before install saying that any funds deposited to this CLN node will automatically be used by clboss to open channels
  2. Add some extra config options for the main clboss preferences: --clboss-min-onchain=, --clboss-auto-close=<true|false>, --clboss-zerobasefee=<require|allow|disallow>, --clboss-min-channel= / --clboss-max-channel=
    3. Add a page that shows the output of "clboss-status" command
    4. Add an "action" for "clboss-unmanage" and similar commands like "clboss-ignore-onchain"
    5. Update instructions with a CLBOSS section

Edit: 3, 4, and 5 moved, see this comment

@swissrouting
Copy link

About point 1, here's an example of the kind of warning notice that could be helpful: https://github.com/rootzoll/raspiblitz/pull/3210/files#diff-163e46a15646dec737558922ccfff387750f8a1a789e5ae2d4404fb0b24b051bR27-R39

@chrisguida
Copy link
Contributor Author

chrisguida commented Jul 11, 2022

Regarding point 1, I've disabled CLBOSS by default for now: d65ccb8

Regarding point 3, this can be accomplished in Spark by visiting the Console and typing clboss-status. Is this sufficient? Adding a UI to CLN just for this might be overengineering a bit. I suppose we could add a CLBOSS section to properties, that's probably ideal.

I'm fine with points 2 and 4 as well

@chrisguida chrisguida changed the title [feat]: enhance CLBOSS config options [feat]: enhance CLBOSS experience Jul 11, 2022
@chrisguida
Copy link
Contributor Author

Fixed by #54.

Splitting out points 3, 4, and 5 into their own issues and adding to next release:

@chrisguida chrisguida moved this to Done in Service Issues Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants