Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with JavaScript code of CustomDataType Charges #182

Closed
plocket opened this issue Jun 8, 2021 · 2 comments
Closed

Error with JavaScript code of CustomDataType Charges #182

plocket opened this issue Jun 8, 2021 · 2 comments
Labels
potentially revisit For low priority, closed issues, but not quite "wontfix"

Comments

@plocket
Copy link
Collaborator

plocket commented Jun 8, 2021

Describe the bug
On the dev server, the test interview shows the log 'Error with JavaScript code of CustomDataType Charges' in the console. Not sure if it appears elsewhere. Looks like it's in the catch for magicsearch

To Reproduce
Steps to reproduce the behavior:

  1. On the dev server, run the test interview
  2. Check the console and see the log

Expected behavior
No error logged.

Version Information (should be in your.docassemble.server/updatepackage:

  • Docassemble Version: 1.2.74
  • AssemblyLine Version: commit 3c3e888

Additional context
Not sure if it's really breaking anything here.

@BryceStevenWilley
Copy link
Contributor

I don't think it's breaking anything, it should just be a console print. It's difficult to actually fix this though, since as we've discussed with Jonathan, this error pops up on every interview even if the offending code is in someone's private playground and isn't installed on the server. Depending on how much time we have this summer I'd like to work with @shanacote to get that feature in the ALToolkit, to fix jhpyle/docassemble#280.

@nonprofittechy
Copy link
Member

It's worth noting that since we bugged Jonathan about this he added support for a "multiselect" type input in Docassemble. That input without styling will be hard to use, but we may be able to just restyle the multiselect that Docassemble creates and avoid the custom datatype.

I have found some examples w/ a mix of JS + CSS that look like they might work for us.

@nonprofittechy nonprofittechy added the potentially revisit For low priority, closed issues, but not quite "wontfix" label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potentially revisit For low priority, closed issues, but not quite "wontfix"
Projects
None yet
Development

No branches or pull requests

3 participants