Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Igen is redundant #80

Open
mikofski opened this issue May 9, 2018 · 0 comments
Open

Igen is redundant #80

mikofski opened this issue May 9, 2018 · 0 comments

Comments

@mikofski
Copy link
Contributor

mikofski commented May 9, 2018

problem

There is both an Igen() method in pvconstants and an Igen property in pvcell

proposal

use the formula in the method as the property, but change Isc0 to just Isc, or just get rid of the formula in pvconstants, AFAIK, it' not used anywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikofski