Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions: add healthcheck type as an optional parameter to environments #536

Open
olevski opened this issue Nov 18, 2024 · 0 comments
Open

Comments

@olevski
Copy link
Member

olevski commented Nov 18, 2024

Amalthea supports currently 3 type checks:

  • http
  • tcp
  • none

The default in amalthea is tcp. So we can defautl to the same value but allow people to specify http which is more robust. The TCP healthcheck can be successful even when the http server is not fully ready.

We should not make this mandatory and allow users to create an environment without worrying about this - unless they know what they are doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant