Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup needs to guess https URL and URI prefixes correctly #778

Closed
cjmyers opened this issue Oct 23, 2024 · 6 comments · May be fixed by #818
Closed

Setup needs to guess https URL and URI prefixes correctly #778

cjmyers opened this issue Oct 23, 2024 · 6 comments · May be fixed by #818
Assignees
@danielfang97
Labels
bug Something isn't working
Milestone
SBH 2.0.0

Comments

@cjmyers
Copy link
Contributor

cjmyers commented Oct 23, 2024

Right now, it is guessing these as http, it needs to guess it as https, if it is running as a secure web server

This setup fix should also be done for SynBioHub 1
@cjmyers cjmyers added the bug Something isn't working label Oct 23, 2024
@cjmyers cjmyers added this to the SBH 2.0.0 milestone Oct 23, 2024
@cjmyers cjmyers self-assigned this Nov 12, 2024
@cjmyers
Copy link
Contributor Author

cjmyers commented Nov 22, 2024

Looks like can use req.secure to know if it is https. Need to do this for by SBH1 and SBH3

@cjmyers
Copy link
Contributor Author

cjmyers commented Nov 22, 2024

Fixed by PR #1580 for SBH1. Still needs fix for SBH2 setup.

@cjmyers cjmyers removed their assignment Nov 22, 2024
@cjmyers
Copy link
Contributor Author

cjmyers commented Nov 27, 2024

Not working on SBH1

@cjmyers cjmyers self-assigned this Nov 27, 2024
@cjmyers
Copy link
Contributor Author

cjmyers commented Nov 29, 2024

Another PR created for SBH1 to hopefully fix this issue

@cjmyers cjmyers removed their assignment Nov 29, 2024
@cjmyers
Copy link
Contributor Author

cjmyers commented Dec 10, 2024

SBH2 is guessing https correctly. However, it is not guessing the backend URL correctly. However, it is not clear how it can guess that. Backend URL cannot be easily guessed, so it must be a required option not an advanced option. It should have instructions that indicate that it should be http://localhost:7777 when testing locally, but it should be the URL of the SBH1 backend otherwise.

@danielfang97 danielfang97 mentioned this issue Dec 15, 2024
Open
@danielfang97
Copy link
Contributor

Closed with #818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielfang97 danielfang97

Labels
bug Something isn't working
Projects
None yet
Milestone
SBH 2.0.0
Development

Successfully merging a pull request may close this issue.

moved backend URL to required. backendURL will look for localhost to … SynBioHub/synbiohub3
2 participants
@cjmyers @danielfang97