Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmarklet import from sites with no schema data fails #3505

Open
tomtjes opened this issue Jan 22, 2025 · 0 comments
Open

Bookmarklet import from sites with no schema data fails #3505

tomtjes opened this issue Jan 22, 2025 · 0 comments

Comments

@tomtjes
Copy link
Contributor

tomtjes commented Jan 22, 2025

Tandoor Version

1.5.30

Setup

Docker / Docker-Compose

Reverse Proxy

SWAG

Other

No response

Bug description

When a website has no Schema data, the bookmarklet import fails.

Example: https://www.bakels.com.au/recipes/yeast-raised-donut/
(this site does have a recipe scraper)

Relevant logs

::ffff:172.30.0.2 - - [22/Jan/2025:22:39:08 +0100] "OPTIONS /api/bookmarklet-import/ HTTP/1.1" 200 0 "https://www.bakels.com.au/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:09 +0100] "POST /api/bookmarklet-import/ HTTP/1.1" 201 675657 "https://www.bakels.com.au/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /data/import/url?id=454 HTTP/1.1" 200 22693 "https://www.bakels.com.au/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/css/app.min.css HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/js/jquery-3.5.1.min.js HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/vue/js/import_view.js HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/themes/tandoor.min.css HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/vue/js/api-chunk.js HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/js/bootstrap.min.js HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/vue/js/locales-chunk.js HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/vue/js/chunk-vendors.js HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/js/popper.min.js HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/css/select2.min.css HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/js/select2.min.js HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/css/select2-bootstrap.css HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/themes/select2-bootstrap-theme.css HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/fontawesome/fontawesome_all.min.css HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/vue/css/chunk-vendors.css HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/vue/css/import_view.css HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/django_js_reverse/reverse.js HTTP/1.1" 304 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /manifest.json HTTP/1.1" 200 1420 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/webfonts/fa-solid-900.woff2 HTTP/1.1" 200 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/webfonts/fa-regular-400.woff2 HTTP/1.1" 200 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/webfonts/poppins_latin_400.woff2 HTTP/1.1" 200 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /api/space/1/ HTTP/1.1" 200 651 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:11 +0100] "GET /static/webfonts/poppins_devanagari_400.woff2 HTTP/1.1" 200 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
Internal Server Error: /api/recipe-from-source/
Traceback (most recent call last):
  File "/opt/recipes/venv/lib/python3.12/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/recipes/venv/lib/python3.12/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/recipes/venv/lib/python3.12/site-packages/django/views/decorators/csrf.py", line 56, in wrapper_view
    return view_func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/recipes/venv/lib/python3.12/site-packages/django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/recipes/venv/lib/python3.12/site-packages/rest_framework/views.py", line 509, in dispatch
    response = self.handle_exception(exc)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/recipes/venv/lib/python3.12/site-packages/rest_framework/views.py", line 469, in handle_exception
    self.raise_uncaught_exception(exc)
  File "/opt/recipes/venv/lib/python3.12/site-packages/rest_framework/views.py", line 480, in raise_uncaught_exception
    raise exc
  File "/opt/recipes/venv/lib/python3.12/site-packages/rest_framework/views.py", line 506, in dispatch
    response = handler(request, *args, **kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/recipes/cookbook/views/api.py", line 1514, in post
    scrape = scrape_html(html=data, org_url='https://urlnotfound.none', supported_only=False)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/recipes/venv/lib/python3.12/site-packages/recipe_scrapers/__init__.py", line 1013, in scrape_html
    raise NoSchemaFoundInWildMode(org_url)
recipe_scrapers._exceptions.NoSchemaFoundInWildMode: recipe-scrapers exception: No Recipe Schema found at https://urlnotfound.none.
ERROR:django.request:Internal Server Error: /api/recipe-from-source/
Traceback (most recent call last):
  File "/opt/recipes/venv/lib/python3.12/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/recipes/venv/lib/python3.12/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/recipes/venv/lib/python3.12/site-packages/django/views/decorators/csrf.py", line 56, in wrapper_view
    return view_func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/recipes/venv/lib/python3.12/site-packages/django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/recipes/venv/lib/python3.12/site-packages/rest_framework/views.py", line 509, in dispatch
    response = self.handle_exception(exc)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/recipes/venv/lib/python3.12/site-packages/rest_framework/views.py", line 469, in handle_exception
    self.raise_uncaught_exception(exc)
  File "/opt/recipes/venv/lib/python3.12/site-packages/rest_framework/views.py", line 480, in raise_uncaught_exception
    raise exc
  File "/opt/recipes/venv/lib/python3.12/site-packages/rest_framework/views.py", line 506, in dispatch
    response = handler(request, *args, **kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/recipes/cookbook/views/api.py", line 1514, in post
    scrape = scrape_html(html=data, org_url='https://urlnotfound.none', supported_only=False)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/recipes/venv/lib/python3.12/site-packages/recipe_scrapers/__init__.py", line 1013, in scrape_html
    raise NoSchemaFoundInWildMode(org_url)
recipe_scrapers._exceptions.NoSchemaFoundInWildMode: recipe-scrapers exception: No Recipe Schema found at https://urlnotfound.none.
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:12 +0100] "POST /api/recipe-from-source/ HTTP/1.1" 500 116179 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:12 +0100] "GET /service-worker.js HTTP/1.1" 200 39291 "" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
::ffff:172.30.0.2 - - [22/Jan/2025:22:39:12 +0100] "GET /static/webfonts/poppins_latin_700.woff2 HTTP/1.1" 200 0 "https://recipes.redacted/data/import/url?id=454" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605.1.15"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomtjes