Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limits on the Climber #201

Open
Nicholas-Stokes opened this issue Mar 11, 2022 · 0 comments
Open

Limits on the Climber #201

Nicholas-Stokes opened this issue Mar 11, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@Nicholas-Stokes
Copy link
Contributor

While we (Robin and I) were testing climber code today, we noticed that there does not seem to be support for encoder limits and we were having problems when the PID would stop working occasionally with the encoders, only to start back up again. To solve this currently, we will have to add more and more case or if statements and just seemingly overcomplicate things.

This doesn't seem like it was actually resolved?

I'll just re-add the comments I put on the pull request


I feel like re-visiting the approach to limiting to the climber mentioned here:

would make it simpler to edit and debug and so we have more flexibility for the Climb Sequence Clint suggested.

@Nicholas-Stokes Nicholas-Stokes added the bug Something isn't working label Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant