Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChannelTabs language option [0.26.0 FR] #10520

Closed
6 tasks done
DI555 opened this issue Oct 29, 2023 · 20 comments
Closed
6 tasks done

ChannelTabs language option [0.26.0 FR] #10520

DI555 opened this issue Oct 29, 2023 · 20 comments
Labels
question Not really an issue, but more of a question about how something works

Comments

@DI555
Copy link

DI555 commented Oct 29, 2023

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

"SETTINGS -> CONTENT -> CHANNEL TABS LANGUAGE"

ChannelTabs language option is the great feature after the plaings of it in the latest dev bulds!

Why do you want this feature?

i saw when devs played with channel tabs language, linked it or to app language or to content language((
and when app lang is differ from the content lang, and differ also from content country, it should be obvious the option to choose channel tabs language!

Additional information

No response

@DI555 DI555 added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Oct 29, 2023
@DI555 DI555 changed the title ChannelTabs language option [2.6.0 FR] ChannelTabs language option [0.26.0 FR] Oct 29, 2023
@opusforlife2
Copy link
Collaborator

It's not clear at all what you're asking for. What is a "channel tab language"?

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Oct 29, 2023
@DI555
Copy link
Author

DI555 commented Oct 30, 2023

it’s a language of names of channel tabs!

..firstly it was chained(depended of) with content language, after the devs skips it and chained(depend) it with app language.., it’s not comfortable it all this way((, especially if you have different language sets for app lang, content lang ang country content option!!!

the feature is about to choose that language of channel tabs manually!

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Oct 30, 2023
@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Oct 30, 2023

We are still not clear what you are talking about. Are you asking for translation of the words (marked within blue box)? Or are you asking for translation of video titles (marked within yellow box)?

Screenshot_20231030-085347

@SameenAhnaf SameenAhnaf added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Oct 30, 2023
@DI555
Copy link
Author

DI555 commented Oct 30, 2023

yep, exactly.., those in bllue box!

but i didn’t know that it’s translations, i thought it’s parcing from the web((

as i know, those in yellow box, is depending from "default content language" option.., is it right? (or "default content country" one???)

so, would be great and to rule those in blue box either separately!

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Oct 30, 2023
@opusforlife2
Copy link
Collaborator

The blue box stuff will be translated by contributors on Weblate. You can see if your language has been done or not yet.


In the future, please state only what your exact feature request is. There's no need for extra commentary on what devs were doing etc. That just makes it harder to understand what you're talking about.

@opusforlife2 opusforlife2 added question Not really an issue, but more of a question about how something works and removed feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Oct 31, 2023
@DI555
Copy link
Author

DI555 commented Oct 31, 2023

@opusforlife2 it’s NOT a question, it’s a FR!

it appeared when devs started playing with this channel tabs language a week ago. and changed in test builds linkage of that channel tabs language according from default page language to app language!
Do not close this fr, as you don’t solve it!

@opusforlife2
Copy link
Collaborator

Can you provide a link to this change?

@DI555
Copy link
Author

DI555 commented Oct 31, 2023

sure, it was skipping in # 90 nightly build, so since # 90 build - channel tabs language became according to app language option!

before and including # 89 build - tabs channel language was according to default content language option.

@opusforlife2
Copy link
Collaborator

channel tabs language became according to app language option

Yes because those tabs are part of the UI, just like the main page tabs. So this is correct.


Don't use # as a numbering symbol. Github uses it for linking PRs and issues. So now your comment references two random PRs that have nothing to do with this issue.

@DI555
Copy link
Author

DI555 commented Oct 31, 2023

and, ok, if not possible for channel tabs language option..
i just can accept an option for channel tabs - to choose its language according between sets in:
app language,
defaulf content language and
default content country,
so it would be more fairy then now and gives a freedom to choose looks of channel tabs!

@opusforlife2
Copy link
Collaborator

Why?

@DI555
Copy link
Author

DI555 commented Oct 31, 2023

Yes because those tabs are part of the UI, just like the main page tabs. So this is correct.

that’s not fully true, because, some ppl thought that is a part of web ui, not app ui ! so would be great to give them an option for that!

@opusforlife2
Copy link
Collaborator

Not everything can be an option. Otherwise we could have language options for the main page tabs, side bar items, menu dialogues, etc. etc.

@DI555
Copy link
Author

DI555 commented Oct 31, 2023

as for me my natioanal language looks ugly now on the channel tabs(as it became linked to app language), and linkage channel tanbs language to default content language or to default content country suits for me more comfortable!!! and i hope i’m not the only one..

@opusforlife2
Copy link
Collaborator

looks ugly now on the channel tabs

Then this is the real issue you should be talking about. Are the words too long compared to the tab length? Can you show a screenshot?

@DI555
Copy link
Author

DI555 commented Oct 31, 2023

no the way! if it was before # 89 "nornally", and someone decided to change it, he had to give to all AN OPTION for that, imo!

@opusforlife2
Copy link
Collaborator

That's not going to happen. If you want the bug to be fixed, please show a screenshot.

@DI555
Copy link
Author

DI555 commented Oct 31, 2023

ok, i’ll try it, but screenshots on my phone are blocked temporarly now((

but it could be easily tested and prooven by installing the nightly builds:
firstly # 89 one, then in settings/content do sets of app language and default content language be differ from each other,
after install over the next nightly build, lets # 91, and vuala, your channel tabs language IS CHANGE!!! ((

@opusforlife2
Copy link
Collaborator

I believe you about this 100%. Not doubting what you say at all.

What is needed from you is the exact language that causes the channel tabs to look ugly. In fact, just name the language. No screenshot needed.

@DI555
Copy link
Author

DI555 commented Oct 31, 2023

as for me it’s really doesn’t matter correcting names of channel tabs in my app language line , because i used to see tabs channels in EN , its more comfortable for me, but and i stand for that it is a part of web ui, not app ui!

anyway, my fr just a good option for all those who think that channel tabs are a part of web ui, and for those who think that is a part of app ui !!!
and will remove discomfortability of a lack option like that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Not really an issue, but more of a question about how something works
Projects
None yet
Development

No branches or pull requests

3 participants