-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll to top feature in comments view #11036
Comments
This comment was marked as spam.
This comment was marked as spam.
Hi, I'm interested in working on this issue, could I please have it assigned to me? |
Hey @katalllen! Thanks for showing an interest in contributing. Unfortunately, the app is undergoing a major refactor right now, and devs are discouraged from sending in feature PRs. You can still do so, but there's a very low probability of them being reviewed any time soon. If you're still okay with that, please go ahead! |
Hi @opusforlife2, I've been working on the issue and I'm struggling to find where the logic for the comments button is instantiated, do you know where I should look for it? I've looked in the VideoDetailFragment as that is the only place the xml that has the comments icon is used, but I ca't find where the logic for the button is, as in I can't find an onClickListener or anything like that. |
I'm not a dev. You're welcome to join the Matrix room (check ReadMe) in order to ask questions. |
The refactor branch contains a scrollbar which is equivalent to having a "scroll to top" button, you can download a testing APK from here: https://github.com/TeamNewPipe/NewPipe-refactor-nightly. Closing as fixed, although expect the refactor branch to be merged on the dev branch in some time. |
Checklist
Feature description
Currently there is no (obvious) way to scroll back to top. User has to manually make many scroll gestures if they are deep into comments.
A workaround is to switch to another tab (related videos) and tap comments again, this puts the video in view.
Ideally, a scroll back to top floating button.
A quick fix: double tapping the comments button (also goes for other tabs)
Why do you want this feature?
Physically tiring to scroll many times, not user-friendly
Additional information
Release 0.27.0
The text was updated successfully, but these errors were encountered: