Option to change font feature

[u7648330]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• giving the option to change font in Setting - Content
• change the font of headings, contents and search

Before/After Screenshots/Screen Record

• Before:
  

• After:
  

Fixes the following issue(s)

• Fixes custom font #10041

APK testing

I tested the APK using the Android Studio Emulator with the following steps:

• Installed the APK on the emulator running Android 13.
• Verified that users can change font from Setting -> Content.
• Checked that there is a Toast prompting the user to restart the app after the user clicked changing font and exited Content page.
• Ensured the there is a font change after restarting the app
• Confirmed no crashes or unexpected behavior during testing.

Due diligence

• I read the contribution guidelines.

[TobiGr]

Thank you for your PR. Due to the influx of new PRs review might take some time. Please let me know if you are an ANU student for internal statistics and because I am writing my master thesis about open source contributions as part of learning computer science and computer science education at university.

[u7648330]

Hi yes I am an anu student.

…

________________________________ From: Tobi ***@***.***> Sent: 27 October 2024 20:41 To: TeamNewPipe/NewPipe ***@***.***> Cc: Vivian Tran ***@***.***>; Author ***@***.***> Subject: Re: [TeamNewPipe/NewPipe] Option to change font feature (PR #11645) Thank you for your PR. Due to the influx of new PRs review might take some time. Please let me know if you are an ANU student for internal statistics and because I am writing my master thesis about open source contributions as part of learning computer science and computer science education at university. — Reply to this email directly, view it on GitHub<#11645 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A6FKZP53QQRKO55ZEF37OJDZ5SRMVAVCNFSM6AAAAABQUOBE4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZZHEZDQOBUGM>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[Stypox]

NewPipe is currently in maintenance mode and is not accepting PRs for new features, as explained on top of the README, especially niche features like this one. Moreover, customizing fonts is off-topic for NewPipe, I now closed the original issue, too. Thank you anyway for your contribution!

[asandikci]

Tested and here my feedback about this PR:

bug:

• repository section in app/build.gradle can cause build error (?). It can be deleted as far as I understand because it is already in outer directory
• Crash on video source change (Already configured. build() must be last invoked method.)

FATAL EXCEPTION: main
Process: APP_NAME, PID: 20230
java.lang.RuntimeException: Unable to start activity ComponentInfo{APP_NAME/org.schabi.newpipe.MainActivity}: java.lang.RuntimeException: Already configured. build() must be last invoked method.
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3134)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3277)
	at ...

enhancements:

• Font is not changing in some tabs/sections: Subscriptions, Settings, About, possibly Downloads, Video Title, Video Options, Video Player
• This setting should be under Appearance instead of Content settings page

additional related feature requests:

• users should be able to upload fonts from local storage
• change font without requiring restart
• users should be able to choose 2 font (1 for menus, 1 for other/general)