Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resources dir conflicts with resources pypi package #15

Open
zed opened this issue Dec 7, 2024 · 0 comments · May be fixed by #16
Open

resources dir conflicts with resources pypi package #15

zed opened this issue Dec 7, 2024 · 0 comments · May be fixed by #16

Comments

@zed
Copy link

zed commented Dec 7, 2024

It is minor (unlikely to be an issue in practice in this specific case) but pytest-textual-snapshot installs its resources folder into global namespace in site-packages e.g., ...venv/lib/python3.11/site-packages/resources that is reserved for actual Python packages.

resources dir could be hidden inside the pytest-textual-snapshot package instead.
zed added a commit to zed/pytest-textual-snapshot that referenced this issue Dec 7, 2024
@zed
🩹 convert into Python package
b40ad84 
to put `resources` inside the `pytest_textual_snapshot` namespace.
To avoid collision with top-level `resources` package. It fixes Textualize#15
@zed zed linked a pull request Dec 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🩹 convert into Python package zed/pytest-textual-snapshot
1 participant
@zed