Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable layout customizations #25

Closed
Tracked by #24
gannebamm opened this issue Jul 19, 2024 · 48 comments
Closed
Tracked by #24

Enable layout customizations #25

gannebamm opened this issue Jul 19, 2024 · 48 comments
Assignees
Labels
EPIC Sub-Portal LB 2.1.1 question Further information is requested

Comments

@gannebamm
Copy link
Contributor

Part of #24

Problem: The current portal shows the Thünen Institutes corporate design. It is therefore not clear to visitors that they are viewing HoliSoil's project results.

Objective: As an administrator, I would like to be able to customize the layout and colors of the sub-portal. The HoliSoils logo and the HoliSoils project colors should be displayed (see https://holisoils.eu/). These customizations should be made possible via templates of the subsites. The HoliSoils CD should be implemented as an example for this and the necessary work steps for future subsites should be documented.

@gannebamm
Copy link
Contributor Author

Vera will get more info

@gannebamm gannebamm added EPIC Sub-Portal LB 2.1.1 question Further information is requested labels Jul 24, 2024
@ridoo ridoo assigned ridoo and kilichenko-pixida and unassigned ridoo Aug 7, 2024
@ridoo
Copy link
Collaborator

ridoo commented Aug 7, 2024

@kilichenko-pixida started having a look at it. Questions to be resolved in the coordination meetings (next is tomorrow)

ridoo added a commit that referenced this issue Aug 8, 2024
@ridoo
Copy link
Collaborator

ridoo commented Aug 8, 2024

Subsites tested/initiated: https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/tree/subsite_holisoils

Use it as a starting point for further customizations. Here's what it looks like at the momenet:

Image

@ridoo
Copy link
Collaborator

ridoo commented Aug 19, 2024

wait for further development to get more input from project members (or @VeraZimt can give earlier input here)

@kilichenko-pixida will work on some documentation until then

@ridoo
Copy link
Collaborator

ridoo commented Aug 22, 2024

Extend documentation to have

  • screenshots (from the admin)
  • list theme snippets?
  • examples

@VeraZimt will invite @ridoo to discuss in detail what to be change

@ridoo
Copy link
Collaborator

ridoo commented Sep 3, 2024

kilichenko-pixida pushed a commit that referenced this issue Sep 3, 2024
kilichenko-pixida pushed a commit that referenced this issue Sep 3, 2024
@ridoo
Copy link
Collaborator

ridoo commented Sep 4, 2024

Sprint Review:

  • Who is responsible to make the style changes?
  • How styling should be actually done? Intended workflow:
    1. Using the Theme Tool
    2. Apply styling via admin interface (theme of the subsite)
    3. Either copy styling to the appropriate custom_theme.html snippet (like here)

kilichenko-pixida pushed a commit that referenced this issue Sep 4, 2024
ridoo added a commit that referenced this issue Oct 1, 2024
@VeraZimt
Copy link

VeraZimt commented Nov 7, 2024

I talked to the persons responsible for the corporate design.
Basis is the demoversion: https://geonode-demo.thuenen.de/holisoils/#/

Changes:

  • consistent use of English (currently wild mixture of DE and EN)
  • font suggestion for digital media is "Poppins" (see p. 16 in styleguide PDF below, I can provide the font if necessary?)
  • does it make sense to have the header (currently "GeoNode Demo" saying HoliSoils and can we put the HS logo in? preferably, it should be flush-left
  • the exact colours of the project are defined in the PDF (styleguide p. 15)
  • footer should contain HoliSoils logo, EU logo/flag and the funding information (as it is in the footer of the HS homepage https://holisoils.eu/ )

I uploaded an overview of logos and the transparent white logo for a trial run

Image
HoliSoilsLogo.pdf

HOLISOILS_STYLEGUIDE.pdf

@VeraZimt
Copy link

VeraZimt commented Nov 7, 2024

The huge white space is the transparent white logo...

@ridoo
Copy link
Collaborator

ridoo commented Nov 7, 2024

@gannebamm are these changes considered to be part of Pixida work? Then, please reply or directly move the ticket to In Progress.

@kilichenko-pixida could you then please have a look once it fits in your schedule or do you need to discuss the changes pointed out by @VeraZimt ?

@kilichenko-pixida
Copy link
Contributor

kilichenko-pixida commented Nov 7, 2024

@gannebamm yes, will be looking into it asap (given a confimation from @gannebamm), but right now I have a couple of questions for @VeraZimt and I think we need to agree what changes to implement.

Where is the German that is referred to? I don't see any on the demo page linked, but maybe I am looking in the wrong place?

About the transparent white logo attached - I am not sure where is it supposed to go? I doesn't look like the logo I see on the HoliSoils page.

Header and fonts are of course should be easy to adjust. About the logo near the header - in the demo version right now the logo in the top left corner is the geonode logo and it could and should be changed in the admin panel in the subsite settings (I don't have access to it), we tested that it works locally. Will it satify the third point when we put it in there? @ridoo do you have access to the demo admin panel?

The one question about the logo is whether it is OK to use the logo like the one we have in the footer (with an existing brown background), because the logo like on the HoliSoild website wouldn't be properly visible. Alternatively we can change the background of the footer and the top serach panel, s.t. we can use the original logo as is.

For the footer I'll add the EU flag with the funding info. And for the colors will look for the mismatches with the guidlilnes. I'll create a new branch for those fixes.

@VeraZimt
Copy link

VeraZimt commented Nov 7, 2024

@kilichenko-pixida The language part is a misunderstanding from me, you are right, everything is fine there.

The idea of the logo was to be put in the header, so that instead of "GeoNode Demo" it says "[Logo]Holisoils" (or just "[Logo]", which already says HS). Replacing the Geonode logo in the top left corner is probably a good idea and then it might be too many logos if there is also one in the header? might look weird.

I think having the footer in the brown background would give a nice frame.

In my first comment, I added a document with an overview of all available logos. The transparent white one was just there to be put in the header, but apparently we don't need it?
I'll put up a folder with all high res logos in a sec but I need to download them individually...

@kilichenko-pixida
Copy link
Contributor

@VeraZimt so we only need to decide whether to have the logo in the upper left corner, in ther header or both, right? In the later option we'll indeed have 3 logos on the page including one in the footer. One logo too many if anyone is askign me

@VeraZimt
Copy link

VeraZimt commented Nov 7, 2024

@kilichenko-pixida Yes, that should be it. I would go for the two logo version (upper left corner and footer), especially because the header is quite big and the logo would be pretty face-slappy there

@VeraZimt
Copy link

VeraZimt commented Nov 7, 2024

@kilichenko-pixida I can only upload the single logos but not the whole folder. I'll send them to you via mail

@kilichenko-pixida
Copy link
Contributor

@ridoo @VeraZimt @gannebamm
Here is a PR #56 with the requested changes, it includes:

  • Colors are updated in accordance with the style guide
  • Font changed to Poppins
  • Logo in the top bar
  • Fixed logos in the footer
  • Proper header and subheader
  • Updated the subsite docs to include instructions on setting up specifically the holisoils subsite

Current look attached
holisoils status

@gannebamm
Copy link
Contributor Author

@VeraZimt the changes are applied to https://geonode-demo.thuenen.de/holisoils/#/

@kilichenko-pixida We want to have sperate Jumbotron contents and left upper side logos for the main portal and the subsite. Is this possible?

The main portal should display the thuenen Logo at the upper left part (left to the search bar) and the jumbotron contents of https://atlas.thuenen.de

@kilichenko-pixida
Copy link
Contributor

@ridoo yes, totally possible, all three of those points are configured in the admin panel for the subsite within its theme settings. I added those steps to the Read.me

@VeraZimt
Copy link

@kilichenko-pixida I guess it looks better with the header centered. do you agree?

@vineetasharma105
Copy link
Contributor

Yes, I also agree Vera. It only looks better in Center

@kilichenko-pixida
Copy link
Contributor

kilichenko-pixida commented Nov 12, 2024

@VeraZimt I think so too, I'll move it back

@kilichenko-pixida
Copy link
Contributor

@gannebamm @VeraZimt Pushed to the PR #56

  • Header is again centered
  • Removed redundunt logos (they were there as part of #26)
  • All 4 internal links will now be working as @vineetasharma105 suggested (footer logos, home button, top left logo)
  • Poppins font is now hosted locally

@VeraZimt
Copy link

Vineeta and I had a talk yesterday about the possibility of an "about" section, where people are introduced to the portal and its functions.
We suggest adding two sencences to the header, stating something like: "A web portal for exploring HoliSoils data. Find out more in the About section"
And then of course the about section itself. The GeoNode main page already has an about section, the HS subsite does not. As a first text and placeholder, I wrote some lines:
"In the course of the HoliSoils project, a lot of data was collected and maps were created. The purpose of this portal is to make the results accessible to anyone who is interested.
The current focus of the portal is on European maps of soil properties in forests. A map of peatlands in the Baltic states and a biodiversity map will follow.
The maps are made to be discovered. On the right-hand side there will always be a statistical overview of the data visible in the current map section. This overview changes continuously when the map section is changed by zooming in.
Try it out!"

@kilichenko-pixida
Copy link
Contributor

@VeraZimt so do you invision the link to the About page being embdded in the header itself or like a dedicated button somewhere on the page?

@VeraZimt
Copy link

I would do it like on the GeoNode page https://geonode-demo.thuenen.de/#/ with an about button on the right, next to the language settings. If the word About in the header is a link to this page, that would be neat

@ridoo
Copy link
Collaborator

ridoo commented Nov 13, 2024

From the sprint meeting:

@ridoo
Copy link
Collaborator

ridoo commented Nov 13, 2024

Regarding the "Writable Subsites":

  • Set SUBSITE_READ_ONLY = False
  • Check the subsite setting Contributors can add resources:
    Image
  • Optionally restrict/extend the permissions to anonymous users
    Image

@gannebamm @vineetasharma105 I tested to add a new resource via subsite: Creation was successful, but could not be shown and was not listed in the overview. The resource (I tested a map) created on a subsite will still "have to be made available" via the main site. What changes are necessary depends on the configuration. In my case it was just assigning the group holisoils group.

@vineetasharma105
Copy link
Contributor

Hi @ridoo : thanks for this info. Sorry I was not able to find where to do this : Set SUBSITE_READ_ONLY = False
Although, I managed to do this :
Image
But , as I already anticipated, it will not have any effect on homepage. Please give me more clarity here.
Also, why this issue has been marked closed ?

@ridoo
Copy link
Collaborator

ridoo commented Nov 13, 2024

Not sure why this got closed. Maybe by accident? Just re-open it 😉

Add the setting to the settings_override.py .. it is not there yet. Just add it.

@vineetasharma105
Copy link
Contributor

okay, let me try this , Thanks Henning :)

@ridoo ridoo reopened this Nov 13, 2024
@ridoo
Copy link
Collaborator

ridoo commented Nov 13, 2024

@vineetasharma105 @gannebamm I re-opened the issue. Feel free to close it once you see everything covered.

@kilichenko-pixida
Copy link
Contributor

kilichenko-pixida commented Nov 15, 2024

@VeraZimt @vineetasharma105

I figured out a way to change the Home button into the "About" button and added an About page with some placehoder content. Changes are local for now. In my understanding and the way I was able to do it, for the additional About page to work, changes to the subsite repo are necessary. So, we'd need our own fork of the subsites repository, s.t. I can make a PR to it. @gannebamm could you please create such a fork? I assume it needs to be owned by Thuenen.

Also, right now all the links in the footer like e.g. "Legal notice" go back to the main portal - is it perhaps desirable for them to be also styled as Holisoils pages? That wouldn't require additional manual setup, so let me know if we'd want to make this change as well. I attach what it might look like.

2

3

@kilichenko-pixida
Copy link
Contributor

Being able to manage all reasources from a susbite might also require some upstream changes to the subsites repo, see this issue

@kilichenko-pixida
Copy link
Contributor

@gannebamm

Some clarifications about a fork of the subsite module I asked about. Docs on the subsite module state the following (part "Advanced: How to override a specific URL"): "Not all the GeoNode URLs are eligible to be used in the subsite. If a new url is required to work with the subsite, it must be added manually to the subsite codebase.".

So, in order to create the About page", I registered it within the subsite module in the dev container and for those changes to actually be applied we'd need to control the code of the subsites module i.e. have our own fork of it.

However, as @ridoo correctly pointed out, it's undesirable to create a fork, as it would potentially mean additional maintanence in the future, so the status as of today is I am looking for a workaround.

@kilichenko-pixida
Copy link
Contributor

kilichenko-pixida commented Nov 19, 2024

@gannebamm

Update on the new About page for the subsite - approach suggested by @ridoo basically worked and we were able to create and register a new subsite page without having to create a fork of the subsites module, which is good. Here is the PR

There is still an open question whether we want to style links like "Developers", "Accessability" etc. as Holisoils pages (see screenshot above)

@vineetasharma105
Copy link
Contributor

Hi @kilichenko-pixida ,
I had a question regarding the style of the links to 'developers', etc. So what I understand is that the url on the 'Developers' is of the home page (https://geonode-demo.thuenen.de/developer/) and so are the other urls. So, if we change the style to Holisoils theme, then will it change on the main portal also ? Or are these tabs ('Developers', etc) local to holisoils subsite ?
As the subsite is part of the main portal and the developers ,etc information (if..) is still common, then I can see that it should be styled as the theme of the home page main portal and not of subsite theme? .. offcourse I have limited understanding here. Please help me out here .

@kilichenko-pixida
Copy link
Contributor

@vineetasharma105 to your first question - what I meant is that the style page would be on a different url and footer links would be different on main page and on the subsite, e.g. /developer and /holisoils/developer. The content would be exactly the same, just the styling would differ and all the navigation links would of course be subsite-specific.

The benefit is of course is that the user wouldn't leave the subsite and can go back easily to any other subsite page. As it is implemented right now, after checking any of the footer links, the user would need to find their way back to the subsite. And some might not even be aware where they ended up and that they have to go press e.g. subsites -> holisoils to go back.

I also don't know how it should be and would appreciate an opinion from @gannebamm and @VeraZimt

@ridoo
Copy link
Collaborator

ridoo commented Nov 21, 2024

@kilichenko-pixida I merged your PR into Thunen Atlas

@gannebamm
Copy link
Contributor Author

is deployed on https://geonode-demo.thuenen.de/holisoils/#/

@kilichenko-pixida
Copy link
Contributor

@gannebamm
I just noticed a strange bug on the deployed version - 3 out of 4 links in the footer lead to a page not found. I have the same version deployed locally and they all work. @ridoo do you have an idea what might be going on?

@gannebamm
Copy link
Contributor Author

Maybe it has to do with the url patterns being overwritten somehow?
https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/blob/thuenen_4.x/geonode/apps/thuenen_app/apps.py#L17-L37

strange behaviour.

@gannebamm
Copy link
Contributor Author

gannebamm commented Nov 22, 2024

@kilichenko-pixida for those:

        re_path(
            r"^legal_notice/$",
            TemplateView.as_view(template_name="legal-notice.html"),
            name="legal-notice",
        ),
        re_path(
            r"^accessibility/$",
            TemplateView.as_view(template_name="accessibility.html"),
            name="accessibility",
        ),
        re_path(
            r"^privacy-cookies/$",
            TemplateView.as_view(template_name="privacy-cookies.html"),
            name="privacy-cookies",

# + developer

They actually SHOULD link back to the homepage contents. The subsite is hosted by Thünen and shall re-use these contents.

@ridoo
Copy link
Collaborator

ridoo commented Nov 26, 2024

I just noticed a strange bug on the deployed version - 3 out of 4 links in the footer lead to a page not found. I have the same version deployed locally and they all work. @ridoo do you have an idea what might be going on?

@kilichenko-pixida could you please double check by cleaning your setup first? I do not expect @gannebamm made changes to local files in the deployment ..

@kilichenko-pixida
Copy link
Contributor

@VeraZimt @ridoo @gannebamm

Regarding making a subsite writable. Currently there are some technical limitations that couldn't be quickly addressed, see upstream issue #43 and also there are some open questions.

Currently as the subsite portal is read-only, there is no user login or registration - is it something that we want to be there? It would certainly be necessary to enable individual portal users to upload dataset or other resources.

If we do allow such uploads - should the user who uploaded the resource be the only one to see it or is the idea that it would appear available for everyone viewing the subsite? Should both be a possibility? We'd probaly need to think about different user privileges in that case.

What are the actual use cases that we have in mind here? If e.g. it's only necessary to now and then upload some new official HoliSoils resource, then perhaps it could be done by just submitting it to Thünen? (just my idea, not sure about the extent to which HoliSoils and Thünen collaborate)

In light of the above it appears to me that resource management on a subsite deserves it's own issue to discuss such requirements and limitations

@ridoo
Copy link
Collaborator

ridoo commented Nov 27, 2024

@VeraZimt @kilichenko-pixida @gannebamm I moved the thuenen_atlas subsite documentation: https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/blob/thuenen_4.x/docs/SUBSITES.md

@ridoo ridoo closed this as completed Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC Sub-Portal LB 2.1.1 question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants