-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable layout customizations #25
Comments
Vera will get more info |
@kilichenko-pixida started having a look at it. Questions to be resolved in the coordination meetings (next is tomorrow) |
Subsites tested/initiated: https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/tree/subsite_holisoils Use it as a starting point for further customizations. Here's what it looks like at the momenet: |
wait for further development to get more input from project members (or @VeraZimt can give earlier input here) @kilichenko-pixida will work on some documentation until then |
First documentation can be found here: https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/blob/thuenen_4.x/geonode/templates/subsites/README.md |
Sprint Review:
|
I talked to the persons responsible for the corporate design. Changes:
I uploaded an overview of logos and the transparent white logo for a trial run |
The huge white space is the transparent white logo... |
@gannebamm are these changes considered to be part of Pixida work? Then, please reply or directly move the ticket to @kilichenko-pixida could you then please have a look once it fits in your schedule or do you need to discuss the changes pointed out by @VeraZimt ? |
@gannebamm yes, will be looking into it asap (given a confimation from @gannebamm), but right now I have a couple of questions for @VeraZimt and I think we need to agree what changes to implement. Where is the German that is referred to? I don't see any on the demo page linked, but maybe I am looking in the wrong place? About the transparent white logo attached - I am not sure where is it supposed to go? I doesn't look like the logo I see on the HoliSoils page. Header and fonts are of course should be easy to adjust. About the logo near the header - in the demo version right now the logo in the top left corner is the geonode logo and it could and should be changed in the admin panel in the subsite settings (I don't have access to it), we tested that it works locally. Will it satify the third point when we put it in there? @ridoo do you have access to the demo admin panel? The one question about the logo is whether it is OK to use the logo like the one we have in the footer (with an existing brown background), because the logo like on the HoliSoild website wouldn't be properly visible. Alternatively we can change the background of the footer and the top serach panel, s.t. we can use the original logo as is. For the footer I'll add the EU flag with the funding info. And for the colors will look for the mismatches with the guidlilnes. I'll create a new branch for those fixes. |
@kilichenko-pixida The language part is a misunderstanding from me, you are right, everything is fine there. The idea of the logo was to be put in the header, so that instead of "GeoNode Demo" it says "[Logo]Holisoils" (or just "[Logo]", which already says HS). Replacing the Geonode logo in the top left corner is probably a good idea and then it might be too many logos if there is also one in the header? might look weird. I think having the footer in the brown background would give a nice frame. In my first comment, I added a document with an overview of all available logos. The transparent white one was just there to be put in the header, but apparently we don't need it? |
@VeraZimt so we only need to decide whether to have the logo in the upper left corner, in ther header or both, right? In the later option we'll indeed have 3 logos on the page including one in the footer. One logo too many if anyone is askign me |
@kilichenko-pixida Yes, that should be it. I would go for the two logo version (upper left corner and footer), especially because the header is quite big and the logo would be pretty face-slappy there |
@kilichenko-pixida I can only upload the single logos but not the whole folder. I'll send them to you via mail |
@ridoo @VeraZimt @gannebamm
|
@VeraZimt the changes are applied to https://geonode-demo.thuenen.de/holisoils/#/ @kilichenko-pixida We want to have sperate Jumbotron contents and left upper side logos for the main portal and the subsite. Is this possible? The main portal should display the thuenen Logo at the upper left part (left to the search bar) and the jumbotron contents of https://atlas.thuenen.de |
@kilichenko-pixida I guess it looks better with the header centered. do you agree? |
Yes, I also agree Vera. It only looks better in Center |
@VeraZimt I think so too, I'll move it back |
@gannebamm @VeraZimt Pushed to the PR #56
|
Vineeta and I had a talk yesterday about the possibility of an "about" section, where people are introduced to the portal and its functions. |
@VeraZimt so do you invision the link to the About page being embdded in the header itself or like a dedicated button somewhere on the page? |
I would do it like on the GeoNode page https://geonode-demo.thuenen.de/#/ with an about button on the right, next to the language settings. If the word About in the header is a link to this page, that would be neat |
From the sprint meeting:
|
Regarding the "Writable Subsites":
@gannebamm @vineetasharma105 I tested to add a new resource via subsite: Creation was successful, but could not be shown and was not listed in the overview. The resource (I tested a map) created on a subsite will still "have to be made available" via the main site. What changes are necessary depends on the configuration. In my case it was just assigning the group |
Hi @ridoo : thanks for this info. Sorry I was not able to find where to do this : Set SUBSITE_READ_ONLY = False |
Not sure why this got closed. Maybe by accident? Just re-open it 😉 Add the setting to the |
okay, let me try this , Thanks Henning :) |
@vineetasharma105 @gannebamm I re-opened the issue. Feel free to close it once you see everything covered. |
I figured out a way to change the Home button into the "About" button and added an About page with some placehoder content. Changes are local for now. In my understanding and the way I was able to do it, for the additional About page to work, changes to the subsite repo are necessary. So, we'd need our own fork of the subsites repository, s.t. I can make a PR to it. @gannebamm could you please create such a fork? I assume it needs to be owned by Thuenen. Also, right now all the links in the footer like e.g. "Legal notice" go back to the main portal - is it perhaps desirable for them to be also styled as Holisoils pages? That wouldn't require additional manual setup, so let me know if we'd want to make this change as well. I attach what it might look like. |
Being able to manage all reasources from a susbite might also require some upstream changes to the subsites repo, see this issue |
Some clarifications about a fork of the subsite module I asked about. Docs on the subsite module state the following (part "Advanced: How to override a specific URL"): "Not all the GeoNode URLs are eligible to be used in the subsite. If a new url is required to work with the subsite, it must be added manually to the subsite codebase.". So, in order to create the About page", I registered it within the subsite module in the dev container and for those changes to actually be applied we'd need to control the code of the subsites module i.e. have our own fork of it. However, as @ridoo correctly pointed out, it's undesirable to create a fork, as it would potentially mean additional maintanence in the future, so the status as of today is I am looking for a workaround. |
Update on the new About page for the subsite - approach suggested by @ridoo basically worked and we were able to create and register a new subsite page without having to create a fork of the subsites module, which is good. Here is the PR There is still an open question whether we want to style links like "Developers", "Accessability" etc. as Holisoils pages (see screenshot above) |
Hi @kilichenko-pixida , |
@vineetasharma105 to your first question - what I meant is that the style page would be on a different url and footer links would be different on main page and on the subsite, e.g. /developer and /holisoils/developer. The content would be exactly the same, just the styling would differ and all the navigation links would of course be subsite-specific. The benefit is of course is that the user wouldn't leave the subsite and can go back easily to any other subsite page. As it is implemented right now, after checking any of the footer links, the user would need to find their way back to the subsite. And some might not even be aware where they ended up and that they have to go press e.g. subsites -> holisoils to go back. I also don't know how it should be and would appreciate an opinion from @gannebamm and @VeraZimt |
@kilichenko-pixida I merged your PR into Thunen Atlas |
is deployed on https://geonode-demo.thuenen.de/holisoils/#/ |
@gannebamm |
Maybe it has to do with the url patterns being overwritten somehow? strange behaviour. |
@kilichenko-pixida for those: re_path(
r"^legal_notice/$",
TemplateView.as_view(template_name="legal-notice.html"),
name="legal-notice",
),
re_path(
r"^accessibility/$",
TemplateView.as_view(template_name="accessibility.html"),
name="accessibility",
),
re_path(
r"^privacy-cookies/$",
TemplateView.as_view(template_name="privacy-cookies.html"),
name="privacy-cookies",
# + developer They actually SHOULD link back to the homepage contents. The subsite is hosted by Thünen and shall re-use these contents. |
@kilichenko-pixida could you please double check by cleaning your setup first? I do not expect @gannebamm made changes to local files in the deployment .. |
Regarding making a subsite writable. Currently there are some technical limitations that couldn't be quickly addressed, see upstream issue #43 and also there are some open questions. Currently as the subsite portal is read-only, there is no user login or registration - is it something that we want to be there? It would certainly be necessary to enable individual portal users to upload dataset or other resources. If we do allow such uploads - should the user who uploaded the resource be the only one to see it or is the idea that it would appear available for everyone viewing the subsite? Should both be a possibility? We'd probaly need to think about different user privileges in that case. What are the actual use cases that we have in mind here? If e.g. it's only necessary to now and then upload some new official HoliSoils resource, then perhaps it could be done by just submitting it to Thünen? (just my idea, not sure about the extent to which HoliSoils and Thünen collaborate) In light of the above it appears to me that resource management on a subsite deserves it's own issue to discuss such requirements and limitations |
@VeraZimt @kilichenko-pixida @gannebamm I moved the thuenen_atlas subsite documentation: https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/blob/thuenen_4.x/docs/SUBSITES.md |
Part of #24
Problem: The current portal shows the Thünen Institutes corporate design. It is therefore not clear to visitors that they are viewing HoliSoil's project results.
Objective: As an administrator, I would like to be able to customize the layout and colors of the sub-portal. The HoliSoils logo and the HoliSoils project colors should be displayed (see https://holisoils.eu/). These customizations should be made possible via templates of the subsites. The HoliSoils CD should be implemented as an example for this and the necessary work steps for future subsites should be documented.
The text was updated successfully, but these errors were encountered: