Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist tries to match team names perfectly #36

Open
casualinformee opened this issue Oct 7, 2020 · 0 comments
Open

Blacklist tries to match team names perfectly #36

casualinformee opened this issue Oct 7, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@casualinformee
Copy link
Contributor

casualinformee commented Oct 7, 2020

Is your feature request related to a problem? Please describe.
The blacklist feature of the script only looks for perfect matches between team names set in config.json and team names searched for in the Teams web app:

blacklist_item = next((bl_team for bl_team in blacklist if bl_team['team_name'] == self.name), None)

This may cause some issues if one or more characters are missing from the team_name value set by a user.

Describe the solution you'd like
I think a more user-friendly way of searching for blacklisted team names would be to see if the team_name string in config.json is contained within the actual team names searched through.

Additional context
See also: #37, where I propose the use of a whitelist instead of a blacklist to search through the appropriate teams. Note: I think the whitelist should search for relevant team names in the same way as described here (checking if team_name is contained rather than checking for an exact match ==).

@TobiasPankner TobiasPankner added the enhancement New feature or request label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants