Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure of complete NFT url uploading #280

Closed
daybreak957 opened this issue Apr 27, 2022 · 3 comments · Fixed by #293
Closed

Failure of complete NFT url uploading #280

daybreak957 opened this issue Apr 27, 2022 · 3 comments · Fixed by #293
Assignees
Labels
bug Something isn't working

Comments

@daybreak957
Copy link

When I open Tokel wallets versions 1.2.1 and 1.2.2 with my seed phrase I am able to view two NFTs and one Early Adopter Token. When I click on the Token I can see the moving image within the wallet. If I click on the url it opens in my browser.

However, when I click on either NFT I can see all the information but there is no image in the wallet. When I click on the url the browser opens but to an error page. I first became aware of this problem when Eureka John sent me my first NFT about a month ago from his interview with NutellaLicka. We messed with it awhile but we're never able to get it open. Even after waiting a month, it never resolved.

I recently won a Tokel NFT from Tokel Talk and was really excited to see if I'd gotten a purple spaceship. Unfortunately, again there was no image in the wallet and the url was broken. After looking closely at the working Token url I rewrote the address in the browser mimicking the working address but with the spaceship identifier and viola! I got the purple spaceship! So happy.

So, what's happening between the creation of the NFT and the receiving of the NFT to the PubKey? I believe that if this glitch is corrected not only will I be able to see my NFTs in the wallet but, we will all be able to see them in the Discord creation feed. But what do I know?!

Here are the steps to recreate the problem.

This is what I see when I open either wallet 👇
image

The address reads: ipfs://bafybeiaiftrw......

If the full url is typed into the browser it works just fine:

https://ipfs.io/ipfs/bafybeiaiftrw4ao2ziegup4ncjff7oimn5fzs4bchscwjnbhxkmfiwkceu

But even that is not technically correct, even if it works to add https://ipfs.io/ipfs/ (dropping the colon and second forward slash).

I went and looked up #43 in the creation-feed and what is listed there is a different url that also works.

https://infura-ipfs.io/ipfs/bafybeiaiftrw4ao2ziegup4ncjff7oimn5fzs4bchscwjnbhxkmfiwkceu

So why does the url change when the NFT is sent to a different wallet?
The abbreviation isn't a functioning link. I hope figuring this out helps you make an even better wallet. I'm really happy with my purple spaceship otherwise.

Daybreak

PS. I have not been able to open the other NFT from John no matter what I type into the browser.
Peace~ Love~ Freedom~

@daybreak957 daybreak957 added the bug Something isn't working label Apr 27, 2022
@lenilsonjr
Copy link
Contributor

The image not loading is tracked on #238. About the link, this Discord message might clarify it: https://discord.com/channels/774497890025472010/781788743228325898/968806874604507156

I have create a new issue on #282 to improve the UX of opening IPFS links on browser gateways when the dApp fails to load media.

I'll close this for now, let me know if you have any other questions or issues. Thanks for engaging and helping improve the dApp! 🙌

@lenilsonjr
Copy link
Contributor

@rannyeribaptist Actually, it's worth investigating in this specific case:

  • if dapp is loading externalMedia.html iframe properly
  • if extractIPFSHash function is extracting the hash properly

If you don't mind, creating a test token that contains the same IPFS link ipfs:// as the screenshot attached might show if there's any issues with our hash parsing setup.

Please check this along #282

@daybreak957
Copy link
Author

Thanks for the follow-up. I've learned a lot about how GitHub works following the links. Don't overlook #255 as it was reviewed but, not solved yet. Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants