Plot non-state variables in Decapodes #315
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows us to plot non-state variables.
Currently, state variables are able to be retrieved from the ODESolution object, and therefore plotted, because they are passed in as initial conditions to the solver. However the variables specified for plotting are stored in a separate field,
plotVars
, and therefore may not have initial conditions.The design decision made in this draft PR intends to also endow variables in plotVars with a default initial condition called "Zeros." The
initial_conditions
function dispatches onZeroes
initial condition type, returningzeros(geometry.dualmesh[:point])
.At the time of opening this draft PR, all variables in the
uuid2symb
mapping are given Zeroes ICs if they are not specified in theinitialConditions
field in the JSON.My question is
ic_specs
) or specified to be plotted, or should every variable be given ICs?