Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong country name for ipdata.co #144

Open
ehsanrasta opened this issue Jul 27, 2019 · 1 comment
Open

Wrong country name for ipdata.co #144

ehsanrasta opened this issue Jul 27, 2019 · 1 comment

Comments

@ehsanrasta
Copy link

Hi
in Torann\GeoIP\Services

should change continent_name to country

public function locate($ip)
{
    // Get data from client
    $data = $this->client->get($ip);

    // Verify server response
    if ($this->client->getErrors() !== null || empty($data[0])) {
        throw new Exception('Request failed (' . $this->client->getErrors() . ')');
    }

    $json = json_decode($data[0], true);

    return $this->hydrate([
        'ip' => $ip,
        'iso_code' => $json['country_code'],
        'country' => $json['continent_name'],
        'city' => $json['city'],
        'state' => $json['region_code'],
        'state_name' => $json['region'],
        'postal_code' => $json['postal'],
        'lat' => $json['latitude'],
        'lon' => $json['longitude'],
        'timezone' => Arr::get($json, 'time_zone.name'),
        'continent' => Arr::get($json, 'continent_code'),
        'currency' => Arr::get($json, 'currency.code'),
    ]);
}
@manoelcalixto
Copy link

I'm waiting for the pull request #141 that resolves this to be accepted by @Torann.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants