-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why yet another database? #91
Comments
I think you've captured most of the rationale behind creating a custom database in your question already. Most data sources list a single color value, which is sufficient for distinguishable presentation, but not as close to the actual signage for example used in the real world (thus not as recognizable). This database stores three colors and the shape, which enable apps to display the line icons more accurately. (Most of the colors in https://taginfo.openstreetmap.org/keys/colour#values e.g. are simply names like "brown" or "orange", whereas we would like the values to be more precise) Another issue are the discrepancies across different sources. This is a problem even found in official materials (sometimes these are vastly different due to e.g. separate maps from the operator of a line and the network it belongs to). We can try to collect the colors for lines within a network from the same source to achieve a coherent look, but when scraping from the different public sources, there is plainly no guarantee for that. And lastly, a custom mapping allows us to easily prepare the data to be used in conjunction with the trip data from Traewelling. |
Closing because of missing response |
Do you have all the data you need? Using your DB format and its identifiers I am unable to see whether there is data missing in my area which I'd be able to provide. Furthermore we could consider adding links to the openstreetmap wiki page so that people looking for this data could find you database. |
I would like to reopen the topic, as in my opinion some problems have arisen in the past that the current CSV cannot map well, such as the sometimes very complex shapes. Wikidata might actually be a good source. Colours are already stored there for many traffic lines. Corresponding icons are also available as SVG, which would make generating your own obsolete and solve the problem with the complex shapes. For the link with e.g. HAFAS Trips, a property might have to be applied for at Wikidata. I have created an automatic list of transport lines in Germany, which shows the current status. Maybe you can already start with the data maintenance there: What is your opinion on this? (Especially @jheubuch, @vainamov, @marhei as you are using the colours in your apps) |
I generally would be fine by that, but anyhow (from a Träwelldroid perspective) I wouldn't like to query Wikidata dataset for every check-in or for every connection on the departure board. The most convenient way would be to anyhow implement that into that Träwelling API that:
|
I'm with @MrKrisKrisu, that SVG icons would improve rendering across all platforms and are probably the only reasonable solution for complex shapes or gradients, but I imagine the hurdle to collect these is much higher than what we currently have. I also agree with @jheubuch that as long as the data is well formatted and readily available, I don't mind where it's coming from. In the current state, I prefer the CSV because it's easily fetch- and cacheable. I think it comes down to this:
|
Couldn't this data be added to an already existing database (OpenStreetMap, Wikidata) and be scraped and aggregated from there if the use-case needs it?
On the other hand your approach is probably easier if you want to get started fast and it seems to work well for instance in endoflife.date, so whatever. Maybe someone will write tools to synchronize data between those databases, maybe someone wont, we'll see 🤔
Some examples of already present data
37% of the world's
route=train
in OSM already have a "colour" tag according to taginfoExample in Wikidata with icon and "sRGB color hex triplet": https://www.wikidata.org/wiki/Q96388302
Now on OSM the same line has a different color set unfortunately: https://www.openstreetmap.org/relation/2552686
The text was updated successfully, but these errors were encountered: