Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time zones (sorry): Times are off for some stations abroad #2992

Open
TudbuT opened this issue Nov 14, 2024 · 3 comments
Open

Time zones (sorry): Times are off for some stations abroad #2992

TudbuT opened this issue Nov 14, 2024 · 3 comments
Labels
bug Something isn't working timezoning is hard

Comments

@TudbuT
Copy link

TudbuT commented Nov 14, 2024

Describe the bug

When trying to check in at stations like Surbiton, London, there is one of these two things happening:

a) upon selecting the train, departure times for future stations are off by +1h.
b) during selecting the train, departure times are off by -1h.

It might be relevant that I have found cases where departure time would be e.g. 22:32 in one screen, and then 23:31 in the other, for the same station. (I found out because in some apps, the dep. station is also shown despite being the departure station, due to the time shift)

Träwelldroid:
Screenshot_20241114_223755_Trwelldroid
Screenshot_20241114_223800_Trwelldroid

Träwelling web:
Screenshot_20241114_223713_Firefox Nightly
Screenshot_20241114_223722_Firefox Nightly

This is irrespective of device timezone. I am reporting this on behalf of a friend who is using the Eu/London timezone, while I am in the Eu/Berlin TZ.

Steps to reproduce

  1. Go to Surbiton in Träwelling
  2. Select a train (e.g. at 22:32)
  3. The destination selection menu contains times one hour ahead of what was selected.

Browser console logs

No response

Browser

No response

@TudbuT TudbuT added the bug Something isn't working label Nov 14, 2024
@marhei
Copy link
Contributor

marhei commented Nov 16, 2024

Hey,

we have the same problem with Lokbuch. The /station/{id}/departures endpoint uses timestamps within the UTC+01:00 timezone
Bildschirmfoto 2024-11-16 um 10 50 01

while the /trains/trip endpoint is using timestamps in UTC+00:00 for the same train without shifting the time by one hour.
Bildschirmfoto 2024-11-16 um 10 53 46

This causes an error in the API implementation of our application as we compare the timestamp to find the correct stop in the case of circular lines.
image

@TheJRB
Copy link

TheJRB commented Nov 23, 2024

Related to this, I'm finding that the workaround of requesting one hour previous is not showing certain trains.

For example, if I try to check in for the 04:41 train from Folkestone West, selecting 03:40 (or 03:41) is not showing me that train. Experiencing this with anything before 05:00 (for 06:00 departures).

image

@Kya-ra
Copy link
Contributor

Kya-ra commented Dec 19, 2024

Just for my 2 cents, I noticed this issue started occuring when the clocks changed in October, exactly day of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working timezoning is hard
Projects
None yet
Development

No branches or pull requests

5 participants