Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclass the PyTorchDetectionTransformer estimator off the PyTorchObjectDetector estimator #2268

Closed
f4str opened this issue Aug 31, 2023 · 1 comment

Comments

@f4str
Copy link
Collaborator

f4str commented Aug 31, 2023

Is your feature request related to a problem? Please describe.
There is a lot of code overlap between the PyTorchDetectionTransformer and PyTorchObjectDetector estimators. This causes bugs to have to be fixed in both locations when reported. Missed changes in one estimator will still remain a bug in the other. In additional, the big overlap in code is redundant and makes it tedious from a maintenance perspective.

Describe the solution you'd like
The PyTorchDetectionTransformer estimator should be subclassed off PyTorchObjectDetector. This will reuse a lot of the code and avoid redundant bugs.

Describe alternatives you've considered
N/A

Additional context
This is purely an codebase housekeeping change. Functionality should not be changed in any way.

@beat-buesser
Copy link
Collaborator

This issue is very closely related to #2267. I think it is better to make both changes in the same pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants