support multi-group log commands #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean Mertz <[email protected]>
With this change, the first argument to the command is parsed as a
regular expression and matched against the list of available log groups.
For each matched log group, the relevant command is executed in
parallel.
The following commands support this pattern:
* `get`
* `streams`
* `watch`
The log group name is added to the formatted log output, to distinguish
logs from different log groups.
If you want to get an idential result as what you got before this
commit, you would have to wrap your group name in regular expression
begin and end tokens, meaning this:
saw stream "my-log-group"
Must now be written as:
saw stream "^my-log-group$"
Signed-off-by: Jean Mertz <[email protected]>
Signed-off-by: Jean Mertz <[email protected]>
Signed-off-by: Jean Mertz <[email protected]>
JeanMertz
force-pushed
the
regexp-group
branch
from
c10be0b to
cdac20f
Compare
|
+1, I would love to see this as part of the project. |
|
+1 from me too, this would be amazing. |
|
+1 on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the first argument to the command is parsed as a
regular expression and matched against the list of available log groups.
For each matched log group, the relevant command is executed in
parallel.
The following commands support this pattern:
getstreamswatchThe log group name is added to the formatted log output, to distinguish
logs from different log groups.
If you want to get an idential result as what you got before this
commit, you would have to wrap your group name in regular expression
begin and end tokens, meaning this:
Must now be written as:
Example output with two groups (
testandtest2):Note that the
saw getcommand makes no attempt to time-sort the events cross-groups.Closes #38