Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight expansion of Topic/Family/after vars #78

Open
dberlow opened this issue Mar 30, 2019 · 11 comments
Open

Slight expansion of Topic/Family/after vars #78

dberlow opened this issue Mar 30, 2019 · 11 comments

Comments

@dberlow
Copy link
Collaborator

dberlow commented Mar 30, 2019

https://variablefonts.typenetwork.com/topics/families/variations

This page was fairly sparse, so I added a bit of text and two small captioned examples (that can't be played with by the user) so they are on the "after vars..." page, with the new text that's edited and waiting for update.

Families:after vars.pdf

@dberlow dberlow assigned ghost Mar 30, 2019
@ghost
Copy link

ghost commented Mar 31, 2019

Added first draft of these illustrations

@dberlow
Copy link
Collaborator Author

dberlow commented Mar 31, 2019

Please correct word in second caption - "...depending on sie preferences"

"...depending on size preferences"

@dberlow
Copy link
Collaborator Author

dberlow commented Mar 31, 2019

Please correct line spacing in first specimen, first and second lines too loose
lose topic

@ghost
Copy link

ghost commented Mar 31, 2019

Weird, I tried to make it tighter the first time and it was cutting the top off the second line. Now it's working now that I've re-typed it all. How is this?

image

@dberlow
Copy link
Collaborator Author

dberlow commented Apr 5, 2019

If the top line is linespaced according to our formula, but uses cap height instead of em height, then I think it'll be right.

So, If you have a tag for all-caps, use it, and for all caps use the Cap ht to calculate linespacing.

There is also a typo in the caption I corrected, "size" for "sie" but it's not updating.

thanks.

ghost pushed a commit that referenced this issue Apr 5, 2019
@ghost
Copy link

ghost commented Apr 5, 2019

Fixed the typo. This screenshot is from TextEdit, so we're stuck with TextEdit's line spacing formula, which seems to only adjust the top of the line. So the space between the first two lines is determined entirely by the linespace setting of the second line.

This is the values I've mocked up currently (different than the one showing on the website):
image

@dberlow
Copy link
Collaborator Author

dberlow commented Apr 5, 2019 via email

@ghost
Copy link

ghost commented Apr 5, 2019

I can do it live, I just thought it was supposed to be a TextEdit screenshot due to the caption in the original PDF.

@dberlow
Copy link
Collaborator Author

dberlow commented Apr 5, 2019 via email

@ghost
Copy link

ghost commented Apr 5, 2019

You can just take this file and adjust them until you like it!
opsz.rtf.zip

@dberlow
Copy link
Collaborator Author

dberlow commented Apr 6, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant