Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New to iOS 14 color space conditionals do not actually exist in iOS 14.0.x #22

Open
UInt2048 opened this issue Oct 30, 2023 · 1 comment
Labels
14.x This issue affects iOS 14 but not some other supported version D: Post-installation bug CRITICAL bug preventing even a single site from loading J: Close in next nightly The issue is solved but the nightly solving it is not released P1: Critical This issue is so important a new release depends on it

Comments

@UInt2048
Copy link
Owner

In CyberKit, we currently have the following in PlatformHave.h:

#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000 \
|| (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \
|| (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 70000) \
|| (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 140000) \
|| (PLATFORM(MACCATALYST) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000))
#define HAVE_CORE_GRAPHICS_CREATE_EXTENDED_COLOR_SPACE 1
#define HAVE_CORE_GRAPHICS_EXTENDED_ADOBE_RGB_1998_COLOR_SPACE 1
#define HAVE_CORE_GRAPHICS_EXTENDED_DISPLAY_P3_COLOR_SPACE 1
#define HAVE_CORE_GRAPHICS_EXTENDED_ITUR_2020_COLOR_SPACE 1
#define HAVE_CORE_GRAPHICS_EXTENDED_ROMMRGB_COLOR_SPACE 1
#endif

Unfortunately, when checking the SDK for 14.0, these things aren't actually there. A crash report from a real device has confirmed this is not an issue with the SDK.

The immediate fix would be to set the conditional to iOS 14.1+ but due to the practice of building CyberKit for major releases, would have the effect of disabling this support until iOS 15, which is not ideal.

Ideally then, in the iOS 14 build, we should surround these usages in functions, especially in ColorSpaceCG.cpp, with runtime checks to confirm iOS 14.1+, so that CyberKit doesn't crash on 14.0, but 14.1+ still gets to use these.

@UInt2048 UInt2048 added the F: Pre-alpha bug Significant bug preventing visiting most sites label Oct 30, 2023
@UInt2048
Copy link
Owner Author

UInt2048 commented Dec 3, 2023

Should be fixed in 5fc73ce. I'll close when there's a nightly to test this.

@UInt2048 UInt2048 added this to the CyberKit v0.0.9 alpha milestone Dec 4, 2023
@UInt2048 UInt2048 closed this as completed Dec 4, 2023
@UInt2048 UInt2048 reopened this Dec 16, 2023
@UInt2048 UInt2048 added J: Close in next nightly The issue is solved but the nightly solving it is not released D: Post-installation bug CRITICAL bug preventing even a single site from loading and removed F: Pre-alpha bug Significant bug preventing visiting most sites labels Jan 27, 2024
@UInt2048 UInt2048 changed the title New to iOS 14 color space conditionals do not actually exist in iOS 14.0 New to iOS 14 color space conditionals do not actually exist in iOS 14.0.x Jan 28, 2024
@UInt2048 UInt2048 added the 14.x This issue affects iOS 14 but not some other supported version label Jan 28, 2024
@UInt2048 UInt2048 added the P1: Critical This issue is so important a new release depends on it label Feb 6, 2024
@UInt2048 UInt2048 reopened this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14.x This issue affects iOS 14 but not some other supported version D: Post-installation bug CRITICAL bug preventing even a single site from loading J: Close in next nightly The issue is solved but the nightly solving it is not released P1: Critical This issue is so important a new release depends on it
Projects
None yet
Development

No branches or pull requests

1 participant