Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signup: Emails sent for "Is X a member" even when user not created.. #83

Open
castaway opened this issue May 12, 2017 · 1 comment
Open

Signup: Emails sent for "Is X a member" even when user not created.. #83

castaway opened this issue May 12, 2017 · 1 comment
Assignees
@castaway
Labels
Review

Comments

@castaway
Copy link
Contributor

This maybe a specific and somewhat minor issue to me using my local mail server - externally any email @mydomain is delivered to me (unless specfically aliased to something else).. but if I send to it internally, non-users get rejected.. thus foo@domain errored, user account wasnt created.. but space email got sent a "Is foo@domain a member"?
@castaway
Copy link
Contributor Author

it occurs to me this will also happen if a user mistypes the domain of the email - so probably still needs fixing .. send to user first, and only to contact if that worked?

@castaway castaway added the ready label Aug 14, 2017
castaway added a commit that referenced this issue Aug 17, 2017
@castaway
Ensure we redisplay signup form with user values after errors
0998bbd 
Fixes #83
castaway added a commit that referenced this issue Aug 18, 2017
@castaway
Send confirmation email after user email
7df5a5f 
* Ensures we don't send it if user-email send fails
* In try/catch block in case it fails too
* Fixes bug #83
@castaway castaway self-assigned this Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@castaway castaway

Labels
Review
Projects
UKHSF Progress Board
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@castaway @idnorton