-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
horizontally varying background error variance #56
Comments
@travissluka Are we supposed to solve this issue right now? Can we make some tests now like you and Jim mentioned at our last meeting? |
@loganchen39 I think we can wait on this. For the first iteration of tests we can use a constant global correlation length and background error variance as discussed. I'll do a PR shortly that fixes the reason it is no longer compiling |
@travissluka I'm back from the SODA project, now I want to work on this project. For starting the tests, my initial thoughts are:
Is my understanding correct? Do you have any comments? |
Currently, the background error variance is effectively 1C. A horizontally varying background error variance needs to be used by providing a
LinearVariableChange
saber::StdDevVariableChange
can be used for this, probably not, it might only be used for the standard deviation when SABER is used to calculate the full covariance from a sample ensemble.multiply
andmultiplyAD
methods. Conceptually it shouldn't be very difficult. See https://github.com/JCSDA-internal/soca/blob/develop/src/soca/Transforms/BkgErr/BkgErr.h for an example with SOCA (though we of course we will but using all C++ instead)For actual standard deviation values to use: we can just create a file with some made up values for now, and then later work on using scientifically meaningful values (perhaps use the data files from the current OISST?)
The text was updated successfully, but these errors were encountered: