Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

🐛 [BUG] - quality___language___fasttext_filter function is not utilizing the 'subset' column's text values for filtering #54

Open
41ow1ives opened this issue May 20, 2024 · 0 comments
Assignees
Labels
Bug Something isn't working WIP Work In Progress (someone is working on this issue!)

Comments

@41ow1ives
Copy link
Collaborator

Environment Settings

default setting

Expected Behavior

The quality___language___fasttext_filter function is not utilizing the 'subset' column's text values for filtering. Although a subset parameter exists in the function, it is not used throughout the logic of the function. However, the function still operates because the language_predict_fasttext function used within automatically targets the 'text' column for filtering. In dataverse testing, the 'text' column is used as the column containing the text. Additionally, there are concerns about potential name conflicts with user input data since the function internally generates columns named labels and scores.

Translate this into easy-to-understand, yet precise English.

Actual Behavior

written above

Reproduction

Simply run with the quality___language___fasttext_filter function without 'text' column.

@41ow1ives 41ow1ives added Bug Something isn't working WIP Work In Progress (someone is working on this issue!) labels May 20, 2024
@41ow1ives 41ow1ives self-assigned this May 20, 2024
@41ow1ives 41ow1ives changed the title 🐛 [BUG] - <title> 🐛 [BUG] - quality___language___fasttext_filter function is not utilizing the 'subset' column's text values for filtering May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working WIP Work In Progress (someone is working on this issue!)
Projects
None yet
Development

No branches or pull requests

1 participant