Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do rolling window offset correction based on file_datetime #11

Open
japhir opened this issue Feb 5, 2023 · 1 comment
Open

do rolling window offset correction based on file_datetime #11

japhir opened this issue Feb 5, 2023 · 1 comment
Labels
enhancement New feature or request someday A feature that would be nice but implementation is deferred until someday in the future

Comments

@japhir
Copy link
Collaborator

japhir commented Feb 5, 2023

in stead of doing it based on the number of measurements before/after the current one (currently a window of 200 around the measurement), do it based on the file_datetime itself so that if there was a holiday or gap in measurements, they don't get added.

Use R package slider for this, especially the slider::hop function.

@japhir japhir added the someday A feature that would be nice but implementation is deferred until someday in the future label Feb 5, 2023
@japhir japhir changed the title SOMEDAY: do rolling window offset correction based on file_datetime do rolling window offset correction based on file_datetime Feb 5, 2023
@japhir japhir added the enhancement New feature or request label Feb 5, 2023
@japhir
Copy link
Collaborator Author

japhir commented Feb 5, 2023

some more old notes:
research rollapply vs time: make offset_correction(_wrapper) work on file_datetime in stead of row so that skipped samples are not taken into account

offset_correction_wrapper

in that case it would be slide_index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request someday A feature that would be nice but implementation is deferred until someday in the future
Projects
None yet
Development

No branches or pull requests

1 participant