Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC guide for React 18 upgrade #1203

Open
8 tasks
bobular opened this issue Sep 14, 2024 · 1 comment
Open
8 tasks

QC guide for React 18 upgrade #1203

bobular opened this issue Sep 14, 2024 · 1 comment

Comments

@bobular
Copy link
Member

bobular commented Sep 14, 2024

This is a guide for how to test the sites following the React 18 upgrade for the client code.

For checking if a bug was already on the live/production site:

  • @aurreco-uga will provide a VectorBase dev site on the live/production site branch that will emulate live sites
  • ortho, mbio and clinepi still have live production sites.

Outreach

  • snackbars - do they still work and look OK? These can be tested as follows: 1. genomics site after changing organism preferences, 2. MapVEu when marker selections (click on markers) are made and various help is given, also notifications when selected markers go off-screen. (due to these changes)
  • do EDA viz thumbnails still all work (plotly plots, simple EDA/clinepi map viz, faceted plots, mbio networks etc) - because these are complex and brittle
  • check the confirm dialogue for analysis deletion works https://qa.clinepidb.org/ce.b34/app/workspace/analyses (due to these changes)
  • check that legacy map redirects (e.g. 'view on map' links from the release 64 notes) work. Not sure how we will test this on qa?? (code changes here)
  • check scroll-to-top button works - should be present in bottom-right (example below) on any website page after you scroll down a bit (code change) image
  • check behaviour of thumbnails at top of gene page (note that these are static images, not dynamic screenshots) (code changes)

Developers

@dmfalke
Copy link
Member

dmfalke commented Sep 14, 2024

  • explain and test registerCustomElement here that is used on some record pages here. Presumably this is something to do with the image rendered near the top of this compound record page.

Good idea. This was an early experiment to allow using custom html tags in the wdk model xml, to use react components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants