Postprocessor newline issue

[nickrsan]

Hi @msdogan,

I just pushed a new version of the postprocessor code (82930a4) to this copy of the calvin repository (not the CWS one). Can you give it a try and see if it resolves the extra newlines on the windows exports for you and then also check and make sure that it doesn't have any unintended side effects on Mac? I tried related code on Windows and Linux with success, but didn't run this actual script, so I'd be curious if it runs correctly on Mac, etc. Thank you!

[mlmaskey]

@nickrsan and @msdogan, I added new lines on this module as follows
Adding new lines to export more information such as objective function values, the matrix of unit cost, and target demand.

Modified lines: 92-94, 139, 147-151, and 180-182

These new features allow the end-user to investigate the objective function values at each link and time step as well as compare the target demand vs supplies.

Mahesh Maskey August 15, 2020

[mlmaskey]

@nickrsan
If it is feasible could you please push to the calvin repository.
Thanks

[msdogan]

@nickrsan I tried on Windows and it runs great, no blank lines. I will try with Mac and let you know.

[msdogan]

I got following error when I tried on Mac.

  File "/Users/msdogan/Documents/github/WSMcalvin/main-annual.py", line 9, in <module>
    calvin = CALVIN('calvin/data/annual/linksWY%d.csv' % i, ic=eop)
  File "/Users/msdogan/Documents/github/WSMcalvin/calvin/calvin.py", line 34, in __init__
    if not self.log.hasHandlers():  # hasHandlers will only be True if someone already called CALVIN with the same log_name in the same session
AttributeError: 'Logger' object has no attribute 'hasHandlers'

[Finished in 9.6s with exit code 1]
[shell_cmd: python -u "/Users/msdogan/Documents/github/WSMcalvin/main-annual.py"]
[dir: /Users/msdogan/Documents/github/WSMcalvin]
[path: /Users/msdogan/anaconda/bin:/Users/msdogan/anaconda/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/TeX/texbin]```

[nickrsan]

Hi Mustafa,

Hmm, any chance that was run using Python 2, or a very old version of Python 3? That error message suggests an old version of Python. If we still need to support Python 2 though, I'll need to change the code - for Python 3, I'd suggest upgrading Python to a newer version.

If you'll be using this computer today, it's probably best to revert to the previous version from Git, but I think you're using a Windows computer for the training? See you momentarily

[msdogan]

Hi Nick,

That's is Python 2.7 installed on my Mac. I will be using Windows for the workshop.

[nickrsan]

OK - do you think we'll want to keep Python 2.7 compatibility or is it OK to drop it? I'll also ask Jon in a pull request.

[msdogan]

Well, it is no problem for me to uninstall Python 2.7 and install 3+. But I believe Jon uses Python 2.7 version.

[msdogan]

Hi @jdherman, do you think we should keep Python 2.7 compatibility?