-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certain characters crash the notification system #32
Comments
Interesting... What OS is this? This module doesn't do much beyond turning around and calling into another PowerShell module per-platform. |
Mac from my understanding. @potatoqualitee Are you able to try with the raw MacNotify module (should already be installed as a dependency of this module)? Function to use would be |
This was on Windows 10; @potatoqualitee 's bot sends the message to PoshNotify and then gets an exception to do with XML. I'll take a look later too. Not sure if she recorded her str but it's on there ;) |
If it was Windows 10, @potatoqualitee, which version of PowerShell was it? I have a hunch what the issue will be in Windows... but it won't be the emoji 😄 |
Thank you, everyone! Such a fast response 😊 I arm running PS version 5.1.19041.610 Maybe I need to throw a .Trim() on that? Something about the /me on Twitch is killing the notifier. |
If you've got a copy of the error handy (even a screenshot from the stream), I can dive in a bit |
It's the weirdest error, but doesn't happen if I remove the notify
how it's related, I have no idea |
Ohh maybe it's .NET |
Hmm. That's a new one for me, and I can't repro 🤔 |
@potatoqualitee; what happens if you send just the string to PoshNotify? I was going to test but I don't think your latest code is up. |
I'll try that on stream momentarily - I just pushed the code to a PR https://github.com/potatoqualitee/tvbot/pull/7/files#diff-3d86d59729663fe1cebc7fca9f571b09cdf789a4d106d0ddbf2e6c71a36301e0R52 |
ah ha!
|
... I need to escape some shiz 😛 In all seriousness, I'd originally made it so that this didn't need to take a dependency on BurntToast. That will change now to fix the 7.1+ issue... and it should also fix this. |
thank you! we ended up escaping and fixing that issue but now we're back to working on .. if we type out emojis it works, but if it's passed emojis by the parsed IRC output, it dies 🤔 |
Hmm. Any visible difference on the string being passed into Title/Body? |
we figured it out!! well, @vexx32 did :D :D :D :D :D let me get you the code that we used
|
Format-Hex is the only way sometimes. 😔 Pesky control characters hidden in the string. |
Hello!
I have a chatbot and when the following text is sent, it crashes my whole bot.
" ☺ACTION 👤 New FOLLOW(S) ❤ username ❤, WELCOME! (1255 followers) (+19).☺"
We think it's that smiley 🤔
The text was updated successfully, but these errors were encountered: